da9063_iic: Add new driver for the Dialog Semiconductor DA9063 PMIC
ClosedPublic
Actions

Authored by jrtc27 on Aug 14 2022, 5:33 PM.

Details

Reviewers

manu
mhorne

Commits

rGe2764afab3fa: da9063_iic: Add new driver for the Dialog Semiconductor DA9063 PMIC
rG80466455adca: da9063_iic: Add new driver for the Dialog Semiconductor DA9063 PMIC

Summary

This is an MFD with regulators, an RTC and a watchdog, among other
things. This adds the necessary infrastructure for specific children to
be added.

Note that the PMIC can also be attached via SPI, not just I2C, and so
the interface is abstracted. No SPI implementation is added, however.

This is the PMIC on SiFive's HiFive Unmatched.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrtc27 created this revision.Aug 14 2022, 5:33 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 14 2022, 5:33 PM

jrtc27 requested review of this revision.Aug 14 2022, 5:33 PM

Harbormaster completed remote builds in B46938: Diff 109334.Aug 14 2022, 5:33 PM

jrtc27 added a child revision: D36200: da9063_rtc: Add new driver for the Dialog Semiconductor DA9063 RTC.Aug 14 2022, 5:34 PM

Just wondering about the path, we don't do per-vendor directory.
We have sys/dev/iicbus/pmic, maybe da9063_iic.c should be there and the rest in a new sys/dev/pmic/dialog directory ?

In D36199#821842, @manu wrote:

Just wondering about the path, we don't do per-vendor directory.
We have sys/dev/iicbus/pmic, maybe da9063_iic.c should be there and the rest in a new sys/dev/pmic/dialog directory ?

We have sys/dev/{altera,cadence,intel,xilinx} already. I'm a bit reluctant to scatter it across the tree as I feel it's nicer to have it all grouped in one place. Also sys/dev/pmic/dialog might suggest that everything under there is PMIC drivers, which da9063_rtc *technically* is but spiritually isn't, it's an RTC that just so happens to in a PMIC chip.

In D36199#821885, @jrtc27 wrote:

In D36199#821842, @manu wrote:

Just wondering about the path, we don't do per-vendor directory.
We have sys/dev/iicbus/pmic, maybe da9063_iic.c should be there and the rest in a new sys/dev/pmic/dialog directory ?

We have sys/dev/{altera,cadence,intel,xilinx} already. I'm a bit reluctant to scatter it across the tree as I feel it's nicer to have it all grouped in one place. Also sys/dev/pmic/dialog might suggest that everything under there is PMIC drivers, which da9063_rtc *technically* is but spiritually isn't, it's an RTC that just so happens to in a PMIC chip.

Yeah ok, fine with me then.
Can you add to the commit message in which board it's found ? (I guess it's one of the sifive board ?)

This revision is now accepted and ready to land.Aug 16 2022, 7:21 AM

jrtc27 mentioned this in D36201: riscv: Add da9063_pmic and da9063_rtc to GENERIC and NOTES.Aug 18 2022, 1:16 AM

mhorne added inline comments.Aug 18 2022, 9:24 PM

sys/dev/dialog/da9063/da9063_if.m
29	I think the functionality of the methods is self-evident, but there should be at least a top-level comment in this file documenting what the interface is for/why it is needed.