hid: add Sony PS5 DualSense controller driver

[chris.longros_gmail.com]

Summary

Add a driver for the Sony PS5 DualSense controller (054c:0ce6)
providing gamepad input via evdev, lightbar RGB LED control, and
player indicator LEDs through sysctl.

Signed-off-by: Christos Longros <[e-mail]>

Test Plan

Tested on FreeBSD 16.0-CURRENT with a PS5 DualSense controller over USB.

• Lightbar LED control: sysctl dev.ps5dualsense.0.led_state=1 (on), =0 (off) — verified lightbar toggles sysctl dev.ps5dualsense.0.led_color_r/g/b — set each channel individually, verified red, green, and blue on the controller lightbar.
• Player indicator LEDs
• Detach/reattach

[imp]

sys/dev/hid/ps5dualsense.c

30

you can delete this line.

[wulf]

sys/dev/hid/ps5dualsense.c

134

Add Output report of 64 bytes total to HID report descriptor. It is used to properly size of USB buffers.

232

should be PS5DS_MAP_ABS(). It does not return to central position being released at least on PS4

233

Ditto

234

should be PS5DS_MAP_FLT(). It does return to central position being released at least on PS4

235

Ditto

236

For PS4 it is processed by hgame_hat_switch_cb() rather than directly mapped to ABS_HAT0X

250

This event belongs to touchpad device rather than game controller

251

May be it should be KEY_MUTE? It is better to consult with Linux driver to find out which device should produce which event after the button is pressed.

430

That is a race with sysctl handlers. Move this line in front of SYSCTL_ADD_PROCs or protect it with sx lock

[chris.longros_gmail.com]

This comment was removed by chris.longros_gmail.com.

[wulf]

Looks mostly good.
There are some missing parts. TODO:

1. Add manpage. You may take share/man/man4/ps4dshock.4 as starting point. Do not forget to add missing touchpad and accelerometer support to BUGS section.
2. Add ps5dualsense.c to sys/conf/files and sys/conf/NOTES
3. Add ps5dualsense subdir to sys/modules/hid/Makefile

sys/dev/hid/ps5dualsense.c

129

Not a bug, but Usage (0x23) is better here as it matches hardware report descriptor.

[wulf]

IMO it would be good to rename driver from ps5dualsense to ps5dsense to be inline with ps4dshock. That is up to you.

[wulf]

sys/dev/hid/ps5dualsense.c

129

I have just glanced at https://controllers.fandom.com/wiki/Sony_DualSense#HID_Report_0x02_Output_USB and found out that Report 1 (input) size is 63 bytes and Report 2 (output) is 47 bytes not including leading ReportID byte. IMO both ps5ds_rdesc[] and PS5DS_OUTPUT_REPORT_USB_SIZE should be corrected to match this values.

[chris.longros_gmail.com]

In D56345#1289609, @wulf wrote:

Looks mostly good.
There are some missing parts. TODO:

1. Add manpage. You may take share/man/man4/ps4dshock.4 as starting point. Do not forget to add missing touchpad and accelerometer support to BUGS section.
2. Add ps5dualsense.c to sys/conf/files and sys/conf/NOTES
3. Add ps5dualsense subdir to sys/modules/hid/Makefile

Thanks for the feedback. I will work on these and push a diff over the next days.