Looks good to me. Other commands use different flags to run in foreground, though. IT's inconsistent...

In D22492#491840, @adamw wrote:

This isn't the right approach. Manpages aren't docs like FAQ and HACKING and DETAILS; they're manpages and their existence shouldn't be controlled by the DOCS option.

There are a couple options we could do:

1. Only touch *.texi and patch the texi sources if DOCS is enabled
2. Add a MANPAGES option
3. Continue touching *.texi and patching the texi sources regardless, but delete the makeinfo line from docs/Makefile.am if DOCS is off
4. Everybody gets texinfo

I like this much better. Thank you.

This isn't the right approach. Manpages aren't docs like FAQ and HACKING and DETAILS; they're manpages and their existence shouldn't be controlled by the DOCS option.

Address review feedback.

Add warning about not autogen

Port builds fine for me, and I wombled my way through node startup without issue, but couldn't get auth working. I think the port is working fine, I just lack the leofs expertise. Mikolaj can you check it please before we push out the changes?

• remove ACE flag from TF and keep flag bits reserved

I think the comment from targets/ should be added in too.

# This file is not autogenerated - take care!

Change locking vm_reserv_reclaim_inactive() following a suggestion
from Jeff: instead of using the scan lock, take the domain lock
and reclaim from the first reservation where trylock succeeds.
Drop the domain lock as soon as the reservation as dequeued. This
way we avoid holding any domain-global reservation locks while the
reservation is being broken.

I will commit the man page separately and MFC it in short order; I will also update it to mention that amd is available from ports (if e.g. someone doesn't want to change their existing config for some reason)

I would like to get more eyeballs from anyone more familiar with CK and epoch(9) to sanity check the idea. If you know of anyone who would be a good reviewer, please let me know or add them directly. Thanks.

databases/leofs: use erlang-runtime21 per review

You cannot use tcp_compute_pipe() with rack. It does not use
the same variables as the default stack. Instead you must use the
ctf_flight_size() function to get whats in flight.

In D22475#491610, @emaste wrote:

I think this is fine, but can you explain the "114 option is already in use for undisclosed purposes at Apple" in more detail?

We would have to come up with an efficient representation for the page granular references. Not just to store but to search. Now that we're not keeping shadow lists on vnode objects you would hope that there wouldn't be a huge number of references but it may be possible with an application that uses fork for concurrency. Like postgres maybe? I haven't looked at the consumers enough to say what the normal bounds are.

In D22423#490985, @jeff wrote:

...

Maybe Alan has some thoughts. I feel like this set of patches is a welcome bandaid but I would've preferred to have done something more architectural to solve it better in the long run.

@pkubaj if you can't commit it, I will be happy to do so.

I guess I should add to please make sure that make -C ${WRKSRC} check completes successfully.

I haven't tested this (I have no way of actually testing it), so I'm relying on you there. You definitely have my approval to commit this whenever you're ready.