Page MenuHomeFreeBSD

Add Makefile.depend.options
ClosedPublic

Authored by sjg on Wed, Nov 20, 9:49 PM.

Details

Reviewers
cy
bdrewery
Group Reviewers
bhyve
Commits
rS355616: Add Makefile.depend.options
Summary

Leaf directories that have dependencies impacted
by options need a Makefile.depend.options file
to avoid churn in Makefile.depend

DIRDEPS for cases such as OPENSSL, TCP_WRAPPERS etc
can be set in local.dirdeps-options.mk
which can add to those set in Makefile.depend.options

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sjg created this revision.Wed, Nov 20, 9:49 PM

I think the comment from targets/ should be added in too.

# This file is not autogenerated - take care!

My only concern is that this is confusing to have 1 autogenerated and 1 manual maintained file. I don't have a better solution except to follow port's example and not use auto generated.

sjg updated this revision to Diff 64699.Thu, Nov 21, 10:34 PM

Add warning about not autogen

bdrewery accepted this revision.Tue, Dec 10, 10:30 PM

I don't like that we have auto generated and manual maintained outside of Makefile as it will get stale fast.

This revision is now accepted and ready to land.Tue, Dec 10, 10:30 PM
This revision was automatically updated to reflect the committed changes.