Page MenuHomeFreeBSD
Differential D22469

Add Makefile.depend.options
ClosedPublic
Actions

Authored by sjg on Nov 20 2019, 9:49 PM.
Tags
None
Referenced Files
F103406803: D22469.diff
Sun, Nov 24, 2:54 PM
F103395726: D22469.diff
Sun, Nov 24, 11:37 AM
Unknown Object (File)
Fri, Nov 22, 10:52 AM
Unknown Object (File)
Fri, Nov 22, 10:51 AM
Unknown Object (File)
Fri, Nov 22, 10:50 AM
Unknown Object (File)
Fri, Nov 22, 10:50 AM
Unknown Object (File)
Fri, Nov 22, 10:28 AM
Unknown Object (File)
Tue, Nov 19, 9:55 PM
View All Files
Subscribers
bcran
bdrewery
donner
emaste
imp
kevans
rgrimes

Details

Reviewers
cy
bdrewery
Group Reviewers
bhyve
Commits
rS355906: Add Makefile.depend.options
rS355616: Add Makefile.depend.options
Summary

Leaf directories that have dependencies impacted
by options need a Makefile.depend.options file
to avoid churn in Makefile.depend

DIRDEPS for cases such as OPENSSL, TCP_WRAPPERS etc
can be set in local.dirdeps-options.mk
which can add to those set in Makefile.depend.options

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27698
Build 25898: arc lint + arc unit

Event Timeline

sjg created this revision.Nov 20 2019, 9:49 PM
Herald added a reviewer: cy. · View Herald TranscriptNov 20 2019, 9:49 PM
Herald added a reviewer: bhyve. · View Herald Transcript
Herald added subscribers: donner, bcran, rgrimes and 4 others. · View Herald Transcript
Harbormaster completed remote builds in B27667: Diff 64647.Nov 20 2019, 9:49 PM
sjg added a reviewer: bdrewery.Nov 20 2019, 9:51 PM
bdrewery added a comment.Nov 21 2019, 9:23 PM

I think the comment from targets/ should be added in too.

# This file is not autogenerated - take care!

My only concern is that this is confusing to have 1 autogenerated and 1 manual maintained file. I don't have a better solution except to follow port's example and not use auto generated.

sjg updated this revision to Diff 64699.Nov 21 2019, 10:34 PM

Add warning about not autogen

Harbormaster completed remote builds in B27698: Diff 64699.Nov 21 2019, 10:34 PM
sjg mentioned this in D22494: Update depends.Nov 22 2019, 12:16 AM
bdrewery accepted this revision.Dec 10 2019, 10:30 PM

I don't like that we have auto generated and manual maintained outside of Makefile as it will get stale fast.

This revision is now accepted and ready to land.Dec 10 2019, 10:30 PM
Closed by commit rS355616: Add Makefile.depend.options (authored by sjg). · Explain WhyDec 11 2019, 5:37 PM
This revision was automatically updated to reflect the committed changes.
sjg added a commit: rS355616: Add Makefile.depend.options.
sjg added a commit: rS355906: Add Makefile.depend.options.Dec 19 2019, 4:58 AM

Revision Contents
Changeset List

PathSize
bin/
ls/
8 lines
lib/
libarchive/
6 lines
libbsnmp/
libbsnmp/
6 lines
libc/
8 lines
libfetch/
9 lines
libpam/
modules/
pam_unix/
8 lines
libpcap/
8 lines
libproc/
11 lines
libradius/
6 lines
libexec/
fingerd/
6 lines
ftpd/
6 lines
telnetd/
6 lines
tftpd/
6 lines
sbin/
dhclient/
8 lines
dumpon/
6 lines
ifconfig/
8 lines
ping/
8 lines
ping6/
8 lines
rtsol/
8 lines
savecore/
10 lines
secure/
usr.bin/
ssh/
6 lines
usr.sbin/
sshd/
6 lines
usr.bin/
brandelf/
8 lines
chkey/
8 lines
chpass/
8 lines
factor/
6 lines
grep/
8 lines
gzip/
8 lines
head/
8 lines
kdump/
10 lines
login/
6 lines
netstat/
8 lines
nm/
8 lines
readelf/
8 lines
size/
8 lines
sort/
8 lines
strings/
8 lines
su/
6 lines
tail/
8 lines
telnet/
11 lines
wc/
8 lines
usr.sbin/
amd/
amd/
6 lines
bhyve/
6 lines
bsnmpd/
bsnmpd/
6 lines
fstyp/
11 lines
gssd/
6 lines
inetd/
6 lines
ngctl/
8 lines
ntp/
ntp-keygen/
6 lines
ntpd/
6 lines
ntpdate/
6 lines
ntpdc/
6 lines
ntpq/
6 lines
sntp/
6 lines
rpcbind/
6 lines
rtsold/
8 lines
sendmail/
8 lines
tcpdump/
tcpdump/
8 lines
traceroute/
8 lines
tzsetup/
10 lines
wpa/
6 lines
ypserv/
6 lines

Diff 64699

View Options

bin/ls/Makefile.depend.options

Loading...
View Options

lib/libarchive/Makefile.depend.options

Loading...
View Options

lib/libbsnmp/libbsnmp/Makefile.depend.options

Loading...
View Options

lib/libc/Makefile.depend.options

Loading...
View Options

lib/libfetch/Makefile.depend.options

Loading...
View Options

lib/libpam/modules/pam_unix/Makefile.depend.options

Loading...
View Options

lib/libpcap/Makefile.depend.options

Loading...
View Options

lib/libproc/Makefile.depend.options

Loading...
View Options

lib/libradius/Makefile.depend.options

Loading...
View Options

libexec/fingerd/Makefile.depend.options

Loading...
View Options

libexec/ftpd/Makefile.depend.options

Loading...
View Options

libexec/telnetd/Makefile.depend.options

Loading...
View Options

libexec/tftpd/Makefile.depend.options

Loading...
View Options

sbin/dhclient/Makefile.depend.options

Loading...
View Options

sbin/dumpon/Makefile.depend.options

Loading...
View Options

sbin/ifconfig/Makefile.depend.options

Loading...
View Options

sbin/ping/Makefile.depend.options

Loading...
View Options

sbin/ping6/Makefile.depend.options

Loading...
View Options

sbin/rtsol/Makefile.depend.options

Loading...
View Options

sbin/savecore/Makefile.depend.options

Loading...
View Options

secure/usr.bin/ssh/Makefile.depend.options

Loading...
View Options

secure/usr.sbin/sshd/Makefile.depend.options

Loading...
View Options

usr.bin/brandelf/Makefile.depend.options

Loading...
View Options

usr.bin/chkey/Makefile.depend.options

Loading...
View Options

usr.bin/chpass/Makefile.depend.options

Loading...
View Options

usr.bin/factor/Makefile.depend.options

Loading...
View Options

usr.bin/grep/Makefile.depend.options

Loading...
View Options

usr.bin/gzip/Makefile.depend.options

Loading...
View Options

usr.bin/head/Makefile.depend.options

Loading...
View Options

usr.bin/kdump/Makefile.depend.options

Loading...
View Options

usr.bin/login/Makefile.depend.options

Loading...
View Options

usr.bin/netstat/Makefile.depend.options

Loading...
View Options

usr.bin/nm/Makefile.depend.options

Loading...
View Options

usr.bin/readelf/Makefile.depend.options

Loading...
View Options

usr.bin/size/Makefile.depend.options

Loading...
View Options

usr.bin/sort/Makefile.depend.options

Loading...
View Options

usr.bin/strings/Makefile.depend.options

Loading...
View Options

usr.bin/su/Makefile.depend.options

Loading...
View Options

usr.bin/tail/Makefile.depend.options

Loading...
View Options

usr.bin/telnet/Makefile.depend.options

Loading...
View Options

usr.bin/wc/Makefile.depend.options

Loading...
View Options

usr.sbin/amd/amd/Makefile.depend.options

Loading...
View Options

usr.sbin/bhyve/Makefile.depend.options

Loading...
View Options

usr.sbin/bsnmpd/bsnmpd/Makefile.depend.options

Loading...
View Options

usr.sbin/fstyp/Makefile.depend.options

Loading...
View Options

usr.sbin/gssd/Makefile.depend.options

Loading...
View Options

usr.sbin/inetd/Makefile.depend.options

Loading...
View Options

usr.sbin/ngctl/Makefile.depend.options

Loading...
View Options

usr.sbin/ntp/ntp-keygen/Makefile.depend.options

Loading...
View Options

usr.sbin/ntp/ntpd/Makefile.depend.options

Loading...
View Options

usr.sbin/ntp/ntpdate/Makefile.depend.options

Loading...
View Options

usr.sbin/ntp/ntpdc/Makefile.depend.options

Loading...
View Options

usr.sbin/ntp/ntpq/Makefile.depend.options

Loading...
View Options

usr.sbin/ntp/sntp/Makefile.depend.options

Loading...
View Options

usr.sbin/rpcbind/Makefile.depend.options

Loading...
View Options

usr.sbin/rtsold/Makefile.depend.options

Loading...
View Options

usr.sbin/sendmail/Makefile.depend.options

Loading...
View Options

usr.sbin/tcpdump/tcpdump/Makefile.depend.options

Loading...
View Options

usr.sbin/traceroute/Makefile.depend.options

Loading...
View Options

usr.sbin/tzsetup/Makefile.depend.options

Loading...
View Options

usr.sbin/wpa/Makefile.depend.options

Loading...
View Options

usr.sbin/ypserv/Makefile.depend.options

Loading...