Page MenuHomeFreeBSD

PR 241526: redis-related infrastructure update
ClosedPublic

Authored by osa on Nov 12 2019, 8:28 PM.

Details

Summary

Redis 5.x is stable and mature enough, so it's time to update database/redis port. However, let's keep existing redis 4.x in a separate port, databases/redis4 for the following reasons: backward compatibility at first and for stability as second (redis 4.x will be supported until redis 6.0 will be released).

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

osa created this revision.Nov 12 2019, 8:28 PM
mat added a subscriber: mat.Nov 13 2019, 4:55 PM

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

mfechner accepted this revision.Nov 13 2019, 5:54 PM

I checked the www/gitlab-ce port and it seems to work fine the new redis version. You only had to adapt your patch, as the port has already version 12.4.2.

This revision is now accepted and ready to land.Nov 13 2019, 5:54 PM
osa added a comment.EditedNov 13 2019, 9:10 PM
In D22336#488662, @mat wrote:

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Thanks for the comment, Mathieu. I've just tried to update the revision and arcanist has failed with Exception Bad origin state 7.
The svn diff -x -U9999 command creates a huge patch, so I don't think I can post it here, so I'm ready to use -U5 in this case.

This revision was automatically updated to reflect the committed changes.