Page MenuHomeFreeBSD

Addition of flag bit definitions in preparation of AccECN
ClosedPublic

Authored by rscheff on Nov 17 2019, 6:23 AM.

Details

Summary

Adding TF flags and SCF (syncache) flags for use with Accurate ECN.
Adding the TCP header Flag for the AE bit, which maps into the upper
portion of the reserved header flags range.
Also marking the last unused flag bit in the TF range, for future use.

These two bits in the TF appear to had prior (~FBSD 5.0, 2003?) use
around some other congestion control (AckCC) mechanism, but were
left unmarked and unclaimed.

This change has no functional changes to existing code.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

  • minimizing delta vs. HEAD (see D22428)

Something really strange here with this diff

Something really strange here with this diff

The raw diff should be ok though...

In D22429#490320, @rscheff_gmx.at wrote:

Something really strange here with this diff

The raw diff should be ok though...

Yes, must be a display artifact in Phabricator.

sys/netinet/tcp_var.h
330 ↗(On Diff #64484)

These flags are also being used in other (uncommitted) patches.
Will move all ECN-related Flags to TF2 instead.

  • remove ACE flag from TF and keep flag bits reserved
This revision is now accepted and ready to land.Dec 31 2019, 2:30 PM