Page MenuHomeFreeBSD

Addition of flag bit definitions in preparation of AccECN
Needs ReviewPublic

Authored by rscheff_gmx.at on Sun, Nov 17, 6:23 AM.

Details

Reviewers
rgrimes
rrs
tuexen
Group Reviewers
transport
Summary

Adding TF flags and SCF (syncache) flags for use with Accurate ECN.
Adding the TCP header Flag for the AE bit, which maps into the upper
portion of the reserved header flags range.
Also marking the last unused flag bit in the TF range, for future use.

These two bits in the TF appear to had prior (~FBSD 5.0, 2003?) use
around some other congestion control (AckCC) mechanism, but were
left unmarked and unclaimed.

This change has no functional changes to existing code.

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 27697
Build 25897: arc lint + arc unit

Event Timeline

rscheff_gmx.at created this revision.Sun, Nov 17, 6:23 AM
  • minimizing delta vs. HEAD (see D22428)

Something really strange here with this diff

Something really strange here with this diff

The raw diff should be ok though...

rgrimes accepted this revision.Sun, Nov 17, 7:21 PM

Something really strange here with this diff

The raw diff should be ok though...

Yes, must be a display artifact in Phabricator.

rscheff_gmx.at added inline comments.Thu, Nov 21, 9:48 PM
sys/netinet/tcp_var.h
330 ↗(On Diff #64484)

These flags are also being used in other (uncommitted) patches.
Will move all ECN-related Flags to TF2 instead.

  • remove ACE flag from TF and keep flag bits reserved