Page MenuHomeFreeBSD
Differential D22428

Editorial change to enhance readability of the TF_* bit constants
ClosedPublic
Actions

Authored by rscheff on Nov 17 2019, 5:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 29, 5:34 AM
Unknown Object (File)
Tue, Dec 16, 11:34 PM
Unknown Object (File)
Nov 27 2025, 2:37 PM
Unknown Object (File)
Nov 22 2025, 1:14 AM
Unknown Object (File)
Nov 20 2025, 2:37 PM
Unknown Object (File)
Nov 20 2025, 2:37 PM
Unknown Object (File)
Nov 20 2025, 2:36 PM
Unknown Object (File)
Nov 20 2025, 2:20 PM
View All Files
Subscribers
imp
melifaro

Details

Reviewers
rgrimes
rrs
tuexen
hiren
Group Reviewers
transport
Commits
rS362871: MFC r355272:
rS355272: Make the TF_* flags easier readable by humans by adding leading zeroes
Summary

This is a minor editorial change to right-align all the
flags defined in the TF* field with leading zeros.

This is not introducing any functional change.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rscheff created this revision.Nov 17 2019, 5:39 AM
Herald added a reviewer: transport. · View Herald TranscriptNov 17 2019, 5:39 AM
Harbormaster completed remote builds in B27601: Diff 64482.Nov 17 2019, 5:39 AM
rscheff mentioned this in D22429: Addition of flag bit definitions in preparation of AccECN.Nov 17 2019, 6:30 AM
rgrimes requested changes to this revision.Nov 17 2019, 7:59 AM
rgrimes added inline comments.
sys/netinet/tcp_var.h
328 ↗(On Diff #64482)

Please document the hole in the bits here

This revision now requires changes to proceed.Nov 17 2019, 7:59 AM
rgrimes accepted this revision.Nov 17 2019, 8:01 AM
rgrimes added inline comments.
sys/netinet/tcp_var.h
328 ↗(On Diff #64482)

Never mind, that well cause issues with the further diffs in this set of changes.

This revision now requires review to proceed.Nov 17 2019, 8:01 AM
rrs accepted this revision.Nov 21 2019, 9:25 PM
This revision is now accepted and ready to land.Nov 21 2019, 9:25 PM
tuexen accepted this revision.Dec 1 2019, 8:36 PM
Closed by commit rS355272: Make the TF_* flags easier readable by humans by adding leading zeroes (authored by tuexen). · Explain WhyDec 1 2019, 8:45 PM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rS355272: Make the TF_* flags easier readable by humans by adding leading zeroes.
Herald added a subscriber: imp. · View Herald TranscriptDec 1 2019, 8:45 PM
tuexen added a commit: rS362871: MFC r355272:.Jul 1 2020, 9:48 PM
Herald added a subscriber: melifaro. · View Herald TranscriptJul 1 2020, 9:48 PM

Revision Contents
Changeset List

PathSize
head/
sys/
netinet/
52 lines

Diff 65106

View Options

head/sys/netinet/tcp_var.h

Loading...