Page MenuHomeFreeBSD

sysctlinfo interface
Needs ReviewPublic

Authored by on Sep 18 2019, 3:55 AM.


Group Reviewers

sysctlinfo is a new interface to explore the sysctl MIB-Tree and to pass the info of the nodes to the userland

The project has: a README, a manual, examples, tests and converted tools.

Test Plan has

testing/ misc tests (name, CTL_MAXNAME levels, etc)
testing/regression/ compatibility with the 'undocumented interface'
testing/time/ for efficiency
testing/lock/ trivial nodes to test lock/system panic

Diff Detail

rS FreeBSD src repository
Lint Skipped
Unit Tests Skipped

Event Timeline edited the summary of this revision. (Show Details)Sep 18 2019, 4:07 AM edited the test plan for this revision. (Show Details)
bcr added a subscriber: bcr.Sep 18 2019, 8:18 AM

Only a minor comma missing in the man page. Otherwise, it's great.
Thank you!


s/format respectively/format, respectively/

This comment was removed by

I' ll update, thank you

update the manual page to address revision feedback

bcr accepted this revision as: manpages.Sep 19 2019, 9:50 AM

OK from manpages. Someone else should look at the actual code to see if there are issues.

kai added a subscriber: kai.Sep 20 2019, 6:35 AM edited the summary of this revision. (Show Details)Sep 28 2019, 5:02 AM edited the test plan for this revision. (Show Details)

Update sysctlinfo.h: CTL_SYSCTL is in sysctl.h
Improve lock (use a shared lock updating sysctl.h/kern_sysctl.c)
Move the implementation to kern_mib.c (sysctlinfo uses nothing from kern_sysctl.c)
Update man/man[3|4]/Makefile