deskutils/py-i3-tomaatti: new port, i3 based pomodoro productivity timer
AbandonedPublic
Actions

Authored by dch on Sep 30 2019, 8:06 AM.

Details

Reviewers

koobs

Test Plan

wip

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 26785
Build 25125: arc lint + arc unit

Event Timeline

dch created this revision.Sep 30 2019, 8:06 AM

Harbormaster completed remote builds in B26785: Diff 62738.Sep 30 2019, 8:06 AM

koobs requested changes to this revision.Sep 30 2019, 8:15 AM

koobs added inline comments.

deskutils/Makefile
204	Sneaky whitespace
deskutils/py-i3-tomaatti/Makefile
3	Project/package is registered in PyPI [1], name it 'tomaatti' accordingly [1] https://pypi.org/project/tomaatti/
15	setup.py doesn't document a version specification for this dependency, so it should be >0
18	Package provides a console_script [1], so must be concurrent safe. Use `USE_PYTHON=concurrent` to handle most things automatically [1] setup.py: 'console_scripts':
20	Use CHEESESHOP as MASTER_SITES unless there's a compelling temporary reason not to, like missing test/license files in the sdist (ask upstream to add them so we can use the PyPI sdist)
24	This is unexpected for a distutils/setuptools supporting Python package. Why is it necessary?
deskutils/py-i3-tomaatti/pkg-descr
11	Is this the wrong pkg-descr for a different package?

This revision now requires changes to proceed.Sep 30 2019, 8:15 AM

kai added a subscriber: kai.Sep 30 2019, 7:52 PM

kai added inline comments.

deskutils/py-i3-tomaatti/Makefile
9	s/dcg/dch/

linimon retitled this revision from Summary: deskutils/py-i3-tomaatti: new port, i3 based pomodoro productivity timer to deskutils/py-i3-tomaatti: new port, i3 based pomodoro productivity timer.Oct 3 2019, 9:27 PM

dch abandoned this revision.Nov 21 2019, 9:01 PM