Differential D22485

random(4): De-export random_sources list
ClosedPublic
Actions

Authored by cem on Nov 21 2019, 6:46 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Mar 8, 10:11 PM

	Unknown Object (File)
	Mon, Feb 24, 9:45 PM

	Unknown Object (File)
	Feb 21 2025, 8:29 AM

	Unknown Object (File)
	Feb 4 2025, 12:54 AM

	Unknown Object (File)
	Jan 27 2025, 1:39 AM

	Unknown Object (File)
	Jan 27 2025, 12:38 AM

	Unknown Object (File)
	Jan 26 2025, 12:29 AM

	Unknown Object (File)
	Jan 25 2025, 7:18 PM

View All 58 Files

Subscribers

Details

Reviewers

delphij
markm
jmg

Group Reviewers

csprng
O3: Kernel Random Numbers Generator

Commits

rS355022: random(4): De-export random_sources list

Summary

The internal datastructures do not need to be visible outside of
random_harvestq, and this helps ensure they are not misused.

No functional change.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem created this revision.Nov 21 2019, 6:46 PM

Harbormaster completed remote builds in B27689: Diff 64685.Nov 21 2019, 6:46 PM

cem added a child revision: D22489: random(4): Make entropy source deregistration safe.Nov 21 2019, 9:07 PM

delphij accepted this revision.Nov 21 2019, 11:22 PM

This revision is now accepted and ready to land.Nov 21 2019, 11:22 PM

markm accepted this revision.Nov 22 2019, 8:00 AM

Closed by commit rS355022: random(4): De-export random_sources list (authored by cem). · Explain WhyNov 22 2019, 8:24 PM

This revision was automatically updated to reflect the committed changes.

cem added a commit: rS355022: random(4): De-export random_sources list.

Owners added a reviewer: O3: Kernel Random Numbers Generator.Nov 22 2019, 8:24 PM

Herald added a reviewer: jmg. · View Herald TranscriptNov 22 2019, 8:24 PM

Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

Packages

head/

sys/

dev/

random/

random_harvestq.c

8 lines

O3: Kernel Random Numbers Generator

2 lines

O3: Kernel Random Numbers Generator

8 lines

O3: Kernel Random Numbers Generator

Diff 64745

head/sys/dev/random/random_harvestq.c

	# $FreeBSD$			# $FreeBSD$

	.PATH: ${SRCTOP}/contrib/pf/ftp-proxy			.PATH: ${SRCTOP}/contrib/pf/ftp-proxy

	PROG= ftp-proxy			PROG= ftp-proxy
	MAN= ftp-proxy.8			MAN= ftp-proxy.8

	SRCS= ftp-proxy.c filter.c			SRCS= ftp-proxy.c filter.c

	CFLAGS+=-I${SRCTOP}/contrib/pf/libevent			CFLAGS+=-I${SRCTOP}/contrib/pf/libevent
				CFLAGS+= -I${SRCTOP}/lib/libpfctl -I${OBJTOP}/lib/libpfctl

	LIBADD= event1			LIBADD= event1 pfctl

	WARNS?= 3			WARNS?= 3

	.include <bsd.prog.mk>			.include <bsd.prog.mk>

head/sys/dev/random/random_infra.c

	# $FreeBSD$			# $FreeBSD$

	.PATH: ${SRCTOP}/contrib/pf/ftp-proxy			.PATH: ${SRCTOP}/contrib/pf/ftp-proxy

	PROG= ftp-proxy			PROG= ftp-proxy
	MAN= ftp-proxy.8			MAN= ftp-proxy.8

	SRCS= ftp-proxy.c filter.c			SRCS= ftp-proxy.c filter.c

	CFLAGS+=-I${SRCTOP}/contrib/pf/libevent			CFLAGS+=-I${SRCTOP}/contrib/pf/libevent
				CFLAGS+= -I${SRCTOP}/lib/libpfctl -I${OBJTOP}/lib/libpfctl

	LIBADD= event1			LIBADD= event1 pfctl

	WARNS?= 3			WARNS?= 3

	.include <bsd.prog.mk>			.include <bsd.prog.mk>

head/sys/dev/random/randomdev.h

	# $FreeBSD$			# $FreeBSD$

	.PATH: ${SRCTOP}/contrib/pf/ftp-proxy			.PATH: ${SRCTOP}/contrib/pf/ftp-proxy

	PROG= ftp-proxy			PROG= ftp-proxy
	MAN= ftp-proxy.8			MAN= ftp-proxy.8

	SRCS= ftp-proxy.c filter.c			SRCS= ftp-proxy.c filter.c

	CFLAGS+=-I${SRCTOP}/contrib/pf/libevent			CFLAGS+=-I${SRCTOP}/contrib/pf/libevent
				CFLAGS+= -I${SRCTOP}/lib/libpfctl -I${OBJTOP}/lib/libpfctl

	LIBADD= event1			LIBADD= event1 pfctl

	WARNS?= 3			WARNS?= 3

	.include <bsd.prog.mk>			.include <bsd.prog.mk>