Page MenuHomeFreeBSD
Differential D33113

amr: remove
ClosedPublic
Actions

Authored by imp on Nov 25 2021, 4:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 10:46 AM
Unknown Object (File)
Sat, Mar 15, 2:50 AM
Unknown Object (File)
Fri, Mar 14, 3:01 PM
Unknown Object (File)
Fri, Mar 14, 1:39 PM
Unknown Object (File)
Fri, Mar 14, 9:16 AM
Unknown Object (File)
Fri, Mar 14, 12:25 AM
Unknown Object (File)
Tue, Mar 11, 5:36 AM
Unknown Object (File)
Tue, Mar 4, 8:21 PM
View All Files
Subscribers
jonathan

Details

Reviewers
scottl
emaste
Group Reviewers
manpages
Commits
rG60de2867c9fc: amr: remove
Summary

Belatedly remove amr(4) and related things.

Sponsored by: Netflix
Noticed by: scottl
Relnotes: yes

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.Nov 25 2021, 4:36 AM
Herald added a reviewer: manpages. · View Herald TranscriptNov 25 2021, 4:36 AM
Herald added a subscriber: jonathan. · View Herald Transcript
imp requested review of this revision.Nov 25 2021, 4:36 AM
imp added a parent revision: D33112: iir: Remove.
Harbormaster completed remote builds in B42966: Diff 98994.Nov 25 2021, 4:36 AM
imp added reviewers: scottl, emaste.Nov 25 2021, 4:38 AM
scottl accepted this revision.Nov 25 2021, 4:49 AM
This revision is now accepted and ready to land.Nov 25 2021, 4:49 AM
Closed by commit rG60de2867c9fc: amr: remove (authored by imp). · Explain WhyNov 25 2021, 7:47 AM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG60de2867c9fc: amr: remove.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
sys/
amd64/
conf/
1 line
conf/
2 lines
4 lines
dev/
amr/
i386/
conf/
1 line
modules/
1 line
amr/
amr_cam/
amr_linux/
tools/
kerneldoc/
subsys/

Diff 99002

View Options

share/man/man4/amr.4

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
#define CAPH_IGNORE_EBADF 0x0001 #define CAPH_IGNORE_EBADF 0x0001
#define CAPH_READ 0x0002 #define CAPH_READ 0x0002
#define CAPH_WRITE 0x0004 #define CAPH_WRITE 0x0004
#define CAPH_LOOKUP 0x0008 #define CAPH_LOOKUP 0x0008
__BEGIN_DECLS __BEGIN_DECLS
static __inline int static const unsigned long caph_stream_cmds[] =
caph_limit_stream(int fd, int flags) { TIOCGETA, TIOCGWINSZ, FIODTYPE };
static const uint32_t caph_stream_fcntls = CAP_FCNTL_GETFL;
static __inline void
caph_stream_rights(cap_rights_t *rights, int flags)
markjUnsubmitted
Done
Inline Actions

I think the backslash is not needed.

markj: I think the backslash is not needed.
{ {
cap_rights_t rights;
unsigned long cmds[] = { TIOCGETA, TIOCGWINSZ, FIODTYPE };
cap_rights_init(&rights, CAP_EVENT, CAP_FCNTL, CAP_FSTAT, cap_rights_init(rights, CAP_EVENT, CAP_FCNTL, CAP_FSTAT,
CAP_IOCTL, CAP_SEEK); CAP_IOCTL, CAP_SEEK);
if ((flags & CAPH_READ) != 0) if ((flags & CAPH_READ) != 0)
cap_rights_set(&rights, CAP_READ); cap_rights_set(rights, CAP_READ);
if ((flags & CAPH_WRITE) != 0) if ((flags & CAPH_WRITE) != 0)
cap_rights_set(&rights, CAP_WRITE); cap_rights_set(rights, CAP_WRITE);
if ((flags & CAPH_LOOKUP) != 0) if ((flags & CAPH_LOOKUP) != 0)
cap_rights_set(&rights, CAP_LOOKUP); cap_rights_set(rights, CAP_LOOKUP);
}
static __inline int
caph_limit_stream(int fd, int flags)
{
cap_rights_t rights;
caph_stream_rights(&rights, flags);
if (cap_rights_limit(fd, &rights) < 0 && errno != ENOSYS) { if (cap_rights_limit(fd, &rights) < 0 && errno != ENOSYS) {
if (errno == EBADF && (flags & CAPH_IGNORE_EBADF) != 0) if (errno == EBADF && (flags & CAPH_IGNORE_EBADF) != 0)
return (0); return (0);
return (-1); return (-1);
} }
if (cap_ioctls_limit(fd, cmds, nitems(cmds)) < 0 && errno != ENOSYS) if (cap_ioctls_limit(fd, caph_stream_cmds,
nitems(caph_stream_cmds)) < 0 && errno != ENOSYS)
return (-1); return (-1);
if (cap_fcntls_limit(fd, CAP_FCNTL_GETFL) < 0 && errno != ENOSYS) if (cap_fcntls_limit(fd, caph_stream_fcntls) < 0 && errno != ENOSYS)
return (-1); return (-1);
return (0); return (0);
} }
static __inline int static __inline int
caph_limit_stdin(void) caph_limit_stdin(void)
{ {
▲ Show 20 Lines • Show All 94 Lines • Show Last 20 Lines
View Options

sys/amd64/conf/GENERIC

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
#define CAPH_IGNORE_EBADF 0x0001 #define CAPH_IGNORE_EBADF 0x0001
#define CAPH_READ 0x0002 #define CAPH_READ 0x0002
#define CAPH_WRITE 0x0004 #define CAPH_WRITE 0x0004
#define CAPH_LOOKUP 0x0008 #define CAPH_LOOKUP 0x0008
__BEGIN_DECLS __BEGIN_DECLS
static __inline int static const unsigned long caph_stream_cmds[] =
caph_limit_stream(int fd, int flags) { TIOCGETA, TIOCGWINSZ, FIODTYPE };
static const uint32_t caph_stream_fcntls = CAP_FCNTL_GETFL;
static __inline void
caph_stream_rights(cap_rights_t *rights, int flags)
markjUnsubmitted
Done
Inline Actions

I think the backslash is not needed.

markj: I think the backslash is not needed.
{ {
cap_rights_t rights;
unsigned long cmds[] = { TIOCGETA, TIOCGWINSZ, FIODTYPE };
cap_rights_init(&rights, CAP_EVENT, CAP_FCNTL, CAP_FSTAT, cap_rights_init(rights, CAP_EVENT, CAP_FCNTL, CAP_FSTAT,
CAP_IOCTL, CAP_SEEK); CAP_IOCTL, CAP_SEEK);
if ((flags & CAPH_READ) != 0) if ((flags & CAPH_READ) != 0)
cap_rights_set(&rights, CAP_READ); cap_rights_set(rights, CAP_READ);
if ((flags & CAPH_WRITE) != 0) if ((flags & CAPH_WRITE) != 0)
cap_rights_set(&rights, CAP_WRITE); cap_rights_set(rights, CAP_WRITE);
if ((flags & CAPH_LOOKUP) != 0) if ((flags & CAPH_LOOKUP) != 0)
cap_rights_set(&rights, CAP_LOOKUP); cap_rights_set(rights, CAP_LOOKUP);
}
static __inline int
caph_limit_stream(int fd, int flags)
{
cap_rights_t rights;
caph_stream_rights(&rights, flags);
if (cap_rights_limit(fd, &rights) < 0 && errno != ENOSYS) { if (cap_rights_limit(fd, &rights) < 0 && errno != ENOSYS) {
if (errno == EBADF && (flags & CAPH_IGNORE_EBADF) != 0) if (errno == EBADF && (flags & CAPH_IGNORE_EBADF) != 0)
return (0); return (0);
return (-1); return (-1);
} }
if (cap_ioctls_limit(fd, cmds, nitems(cmds)) < 0 && errno != ENOSYS) if (cap_ioctls_limit(fd, caph_stream_cmds,
nitems(caph_stream_cmds)) < 0 && errno != ENOSYS)
return (-1); return (-1);
if (cap_fcntls_limit(fd, CAP_FCNTL_GETFL) < 0 && errno != ENOSYS) if (cap_fcntls_limit(fd, caph_stream_fcntls) < 0 && errno != ENOSYS)
return (-1); return (-1);
return (0); return (0);
} }
static __inline int static __inline int
caph_limit_stdin(void) caph_limit_stdin(void)
{ {
▲ Show 20 Lines • Show All 94 Lines • Show Last 20 Lines
View Options

sys/conf/NOTES

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
#define CAPH_IGNORE_EBADF 0x0001 #define CAPH_IGNORE_EBADF 0x0001
#define CAPH_READ 0x0002 #define CAPH_READ 0x0002
#define CAPH_WRITE 0x0004 #define CAPH_WRITE 0x0004
#define CAPH_LOOKUP 0x0008 #define CAPH_LOOKUP 0x0008
__BEGIN_DECLS __BEGIN_DECLS
static __inline int static const unsigned long caph_stream_cmds[] =
caph_limit_stream(int fd, int flags) { TIOCGETA, TIOCGWINSZ, FIODTYPE };
static const uint32_t caph_stream_fcntls = CAP_FCNTL_GETFL;
static __inline void
caph_stream_rights(cap_rights_t *rights, int flags)
markjUnsubmitted
Done
Inline Actions

I think the backslash is not needed.

markj: I think the backslash is not needed.
{ {
cap_rights_t rights;
unsigned long cmds[] = { TIOCGETA, TIOCGWINSZ, FIODTYPE };
cap_rights_init(&rights, CAP_EVENT, CAP_FCNTL, CAP_FSTAT, cap_rights_init(rights, CAP_EVENT, CAP_FCNTL, CAP_FSTAT,
CAP_IOCTL, CAP_SEEK); CAP_IOCTL, CAP_SEEK);
if ((flags & CAPH_READ) != 0) if ((flags & CAPH_READ) != 0)
cap_rights_set(&rights, CAP_READ); cap_rights_set(rights, CAP_READ);
if ((flags & CAPH_WRITE) != 0) if ((flags & CAPH_WRITE) != 0)
cap_rights_set(&rights, CAP_WRITE); cap_rights_set(rights, CAP_WRITE);
if ((flags & CAPH_LOOKUP) != 0) if ((flags & CAPH_LOOKUP) != 0)
cap_rights_set(&rights, CAP_LOOKUP); cap_rights_set(rights, CAP_LOOKUP);
}
static __inline int
caph_limit_stream(int fd, int flags)
{
cap_rights_t rights;
caph_stream_rights(&rights, flags);
if (cap_rights_limit(fd, &rights) < 0 && errno != ENOSYS) { if (cap_rights_limit(fd, &rights) < 0 && errno != ENOSYS) {
if (errno == EBADF && (flags & CAPH_IGNORE_EBADF) != 0) if (errno == EBADF && (flags & CAPH_IGNORE_EBADF) != 0)
return (0); return (0);
return (-1); return (-1);
} }
if (cap_ioctls_limit(fd, cmds, nitems(cmds)) < 0 && errno != ENOSYS) if (cap_ioctls_limit(fd, caph_stream_cmds,
nitems(caph_stream_cmds)) < 0 && errno != ENOSYS)
return (-1); return (-1);
if (cap_fcntls_limit(fd, CAP_FCNTL_GETFL) < 0 && errno != ENOSYS) if (cap_fcntls_limit(fd, caph_stream_fcntls) < 0 && errno != ENOSYS)
return (-1); return (-1);
return (0); return (0);
} }
static __inline int static __inline int
caph_limit_stdin(void) caph_limit_stdin(void)
{ {
▲ Show 20 Lines • Show All 94 Lines • Show Last 20 Lines
View Options

sys/conf/files

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
#define CAPH_IGNORE_EBADF 0x0001 #define CAPH_IGNORE_EBADF 0x0001
#define CAPH_READ 0x0002 #define CAPH_READ 0x0002
#define CAPH_WRITE 0x0004 #define CAPH_WRITE 0x0004
#define CAPH_LOOKUP 0x0008 #define CAPH_LOOKUP 0x0008
__BEGIN_DECLS __BEGIN_DECLS
static __inline int static const unsigned long caph_stream_cmds[] =
caph_limit_stream(int fd, int flags) { TIOCGETA, TIOCGWINSZ, FIODTYPE };
static const uint32_t caph_stream_fcntls = CAP_FCNTL_GETFL;
static __inline void
caph_stream_rights(cap_rights_t *rights, int flags)
markjUnsubmitted
Done
Inline Actions

I think the backslash is not needed.

markj: I think the backslash is not needed.
{ {
cap_rights_t rights;
unsigned long cmds[] = { TIOCGETA, TIOCGWINSZ, FIODTYPE };
cap_rights_init(&rights, CAP_EVENT, CAP_FCNTL, CAP_FSTAT, cap_rights_init(rights, CAP_EVENT, CAP_FCNTL, CAP_FSTAT,
CAP_IOCTL, CAP_SEEK); CAP_IOCTL, CAP_SEEK);
if ((flags & CAPH_READ) != 0) if ((flags & CAPH_READ) != 0)
cap_rights_set(&rights, CAP_READ); cap_rights_set(rights, CAP_READ);
if ((flags & CAPH_WRITE) != 0) if ((flags & CAPH_WRITE) != 0)
cap_rights_set(&rights, CAP_WRITE); cap_rights_set(rights, CAP_WRITE);
if ((flags & CAPH_LOOKUP) != 0) if ((flags & CAPH_LOOKUP) != 0)
cap_rights_set(&rights, CAP_LOOKUP); cap_rights_set(rights, CAP_LOOKUP);
}
static __inline int
caph_limit_stream(int fd, int flags)
{
cap_rights_t rights;
caph_stream_rights(&rights, flags);
if (cap_rights_limit(fd, &rights) < 0 && errno != ENOSYS) { if (cap_rights_limit(fd, &rights) < 0 && errno != ENOSYS) {
if (errno == EBADF && (flags & CAPH_IGNORE_EBADF) != 0) if (errno == EBADF && (flags & CAPH_IGNORE_EBADF) != 0)
return (0); return (0);
return (-1); return (-1);
} }
if (cap_ioctls_limit(fd, cmds, nitems(cmds)) < 0 && errno != ENOSYS) if (cap_ioctls_limit(fd, caph_stream_cmds,
nitems(caph_stream_cmds)) < 0 && errno != ENOSYS)
return (-1); return (-1);
if (cap_fcntls_limit(fd, CAP_FCNTL_GETFL) < 0 && errno != ENOSYS) if (cap_fcntls_limit(fd, caph_stream_fcntls) < 0 && errno != ENOSYS)
return (-1); return (-1);
return (0); return (0);
} }
static __inline int static __inline int
caph_limit_stdin(void) caph_limit_stdin(void)
{ {
▲ Show 20 Lines • Show All 94 Lines • Show Last 20 Lines
View Options

sys/dev/amr/amr.c

Loading...
View Options

sys/dev/amr/amr_cam.c

Loading...
View Options

sys/dev/amr/amr_disk.c

Loading...
View Options

sys/dev/amr/amr_linux.c

Loading...
View Options

sys/dev/amr/amr_pci.c

Loading...
View Options

sys/dev/amr/amr_tables.h

Loading...
View Options

sys/dev/amr/amrio.h

Loading...
View Options

sys/dev/amr/amrreg.h

Loading...
View Options

sys/dev/amr/amrvar.h

Loading...
View Options

sys/i386/conf/GENERIC

Loading...
View Options

sys/modules/Makefile

Loading...
View Options

sys/modules/amr/Makefile

Loading...
View Options

sys/modules/amr/amr_cam/Makefile

Loading...
View Options

sys/modules/amr/amr_linux/Makefile

Loading...
View Options

tools/kerneldoc/subsys/Doxyfile-dev_amr

Loading...