Page MenuHomeFreeBSD
Differential D45498

sys/conf: Introduce NOSAN_CFLAGS and NOSAN_C
ClosedPublic
Actions

Authored by andrew on Jun 5 2024, 12:57 PM.
Tags
None
Referenced Files
F174702192: D45498.id142232.diff
Mon, Oct 5, 8:28 AM
F174630613: D45498.id142232.diff
Sun, Oct 4, 7:25 PM
F174626017: D45498.id139952.diff
Sun, Oct 4, 6:47 PM
F174607794: D45498.diff
Sun, Oct 4, 3:36 PM
F174605054: D45498.id139691.diff
Sun, Oct 4, 3:03 PM
F174594223: D45498.id139507.diff
Sun, Oct 4, 12:54 PM
Unknown Object (File)
Sat, Oct 3, 1:01 PM
Unknown Object (File)
Sat, Sep 26, 12:47 PM
View All Files
Subscribers
emaste
rgrimes

Details

Reviewers
markj
imp
jhb
brooks
khng
Commits
rG12a6257a9600: sys/conf: Introduce NOSAN_CFLAGS and NOSAN_C
Summary

To simplify disabling the kernel sanitizers in some files add
NOSAN_CFLAGS and NOSAN_C variables. These are CFLAGS and NORMAL_C with
the sanitizer flags removed.

While here add MSAN_CFLAGS to simplify keeping KMSAN in kern_kcov.c

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58127
Build 55015: arc lint + arc unit

Event Timeline

andrew created this revision.Jun 5 2024, 12:57 PM
Herald added subscribers: rgrimes, emaste. · View Herald TranscriptJun 5 2024, 12:57 PM
andrew requested review of this revision.Jun 5 2024, 12:57 PM
Harbormaster completed remote builds in B58064: Diff 139507.Jun 5 2024, 12:57 PM
andrew mentioned this in D45300: sys/conf: Support building kasan with gcc on arm64.Jun 5 2024, 1:03 PM
andrew added a child revision: D45300: sys/conf: Support building kasan with gcc on arm64.Jun 5 2024, 1:03 PM
markj accepted this revision.Jun 5 2024, 1:53 PM

Sorry for not having done this when I added the -fno-sanitize* pattern.

This revision is now accepted and ready to land.Jun 5 2024, 1:53 PM
brooks accepted this revision.Jun 5 2024, 4:46 PM
imp accepted this revision.Jun 5 2024, 5:09 PM
andrew updated this revision to Diff 139691.Jun 10 2024, 4:49 PM

Fix the module build. NOSAN_CFLAGS was wrong when used in kmod.mk

This revision now requires review to proceed.Jun 10 2024, 4:49 PM
Harbormaster completed remote builds in B58127: Diff 139691.Jun 10 2024, 4:49 PM
markj added inline comments.Jun 11 2024, 2:07 PM
sys/conf/kern.pre.mk
220

Does it not work to define these in kern.mk instead of here and in kmod.mk?

markj mentioned this in D45563: sys: move SAN and COVERAGE options handling to kern.mk.Jun 11 2024, 10:37 PM
andrew updated this revision to Diff 139952.Jun 18 2024, 1:45 PM

Move NOSAN_CFLAGS to kern.mk

Harbormaster completed remote builds in B58218: Diff 139952.Jun 18 2024, 1:45 PM
khng accepted this revision.Jun 19 2024, 4:38 PM
This revision is now accepted and ready to land.Jun 19 2024, 4:38 PM
markj accepted this revision.Jun 20 2024, 3:49 PM
markj added inline comments.
sys/conf/kern.mk
297 ↗(On Diff #139952)

Maybe mention NOSAN_C in a comment here.

Closed by commit rG12a6257a9600: sys/conf: Introduce NOSAN_CFLAGS and NOSAN_C (authored by andrew). · Explain WhyAug 20 2024, 9:02 AM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG12a6257a9600: sys/conf: Introduce NOSAN_CFLAGS and NOSAN_C.

Revision Contents
Changeset List

PathSize
sys/
conf/
10 lines
6 lines
6 lines
11 lines
7 lines
modules/
linux64/
3 lines
vmm/
15 lines

Diff 139691

View Options

sys/conf/files

Loading...
View Options

sys/conf/files.arm64

Loading...
View Options

sys/conf/kern.post.mk

Loading...
View Options

sys/conf/kern.pre.mk

Loading...
View Options

sys/conf/kmod.mk

Loading...
View Options

sys/modules/linux64/Makefile

Loading...
View Options

sys/modules/vmm/Makefile

Loading...