Paths

Table of Contentst

Differential D45498

sys/conf: Introduce NOSAN_CFLAGS and NOSAN_C
ClosedPublic
Actions

Authored by andrew on Jun 5 2024, 12:57 PM.

Project Tags

None

Referenced Files

None

Subscribers

emaste

rgrimes

Details

Reviewers

markj
imp
jhb
brooks
khng

Commits

rG12a6257a9600: sys/conf: Introduce NOSAN_CFLAGS and NOSAN_C

Summary

To simplify disabling the kernel sanitizers in some files add
NOSAN_CFLAGS and NOSAN_C variables. These are CFLAGS and NORMAL_C with
the sanitizer flags removed.

While here add MSAN_CFLAGS to simplify keeping KMSAN in kern_kcov.c

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Jun 5 2024, 12:57 PM

Herald added subscribers: rgrimes, emaste. · View Herald TranscriptJun 5 2024, 12:57 PM

andrew requested review of this revision.Jun 5 2024, 12:57 PM

Harbormaster completed remote builds in B58064: Diff 139507.Jun 5 2024, 12:57 PM

andrew mentioned this in D45300: sys/conf: Support building kasan with gcc on arm64.Jun 5 2024, 1:03 PM

andrew added a child revision: D45300: sys/conf: Support building kasan with gcc on arm64.Jun 5 2024, 1:03 PM

Sorry for not having done this when I added the -fno-sanitize* pattern.

This revision is now accepted and ready to land.Jun 5 2024, 1:53 PM

brooks accepted this revision.Jun 5 2024, 4:46 PM

imp accepted this revision.Jun 5 2024, 5:09 PM

Fix the module build. NOSAN_CFLAGS was wrong when used in kmod.mk

This revision now requires review to proceed.Jun 10 2024, 4:49 PM

Harbormaster completed remote builds in B58127: Diff 139691.Jun 10 2024, 4:49 PM

markj added inline comments.Jun 11 2024, 2:07 PM

sys/conf/kern.pre.mk
220	Does it not work to define these in kern.mk instead of here and in kmod.mk?

markj mentioned this in D45563: sys: move SAN and COVERAGE options handling to kern.mk.Jun 11 2024, 10:37 PM

Move NOSAN_CFLAGS to kern.mk

Harbormaster completed remote builds in B58218: Diff 139952.Jun 18 2024, 1:45 PM

khng accepted this revision.Jun 19 2024, 4:38 PM

This revision is now accepted and ready to land.Jun 19 2024, 4:38 PM

markj accepted this revision.Jun 20 2024, 3:49 PM

markj added inline comments.

sys/conf/kern.mk
297	Maybe mention `NOSAN_C` in a comment here.

Closed by commit rG12a6257a9600: sys/conf: Introduce NOSAN_CFLAGS and NOSAN_C. · Explain WhyAug 20 2024, 9:02 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG12a6257a9600: sys/conf: Introduce NOSAN_CFLAGS and NOSAN_C.

Revision Contents
Changeset List

Path

Size

sys/

conf/

10 lines

6 lines

2 lines

6 lines

9 lines

4 lines

modules/

linux64/

Makefile

3 lines

vmm/

Makefile

15 lines

Diff 142232

View Options

sys/conf/files

View Options

sys/conf/files.arm64

View Options

sys/conf/kern.mk

View Options

sys/conf/kern.post.mk

View Options

sys/conf/kern.pre.mk

View Options

sys/conf/kmod.mk

View Options

sys/modules/linux64/Makefile

View Options

sys/conf: Introduce NOSAN_CFLAGS and NOSAN_CClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 142232

sys/conf/files

sys/conf/files.arm64

sys/conf/kern.mk

sys/conf/kern.post.mk

sys/conf/kern.pre.mk

sys/conf/kmod.mk

sys/modules/linux64/Makefile

sys/modules/vmm/Makefile

sys/conf: Introduce NOSAN_CFLAGS and NOSAN_C
ClosedPublic
Actions

Revision Contents
Changeset List