Page MenuHomeFreeBSD
Differential D45300

sys/conf: Support building kasan with gcc on arm64
ClosedPublic
Actions

Authored by andrew on May 22 2024, 2:35 PM.
Tags
None
Referenced Files
F170652911: D45300.id144936.diff
Sat, Sep 5, 8:09 PM
Unknown Object (File)
Fri, Sep 4, 3:10 PM
Unknown Object (File)
Thu, Sep 3, 11:22 PM
Unknown Object (File)
Wed, Sep 2, 9:34 AM
Unknown Object (File)
Mon, Aug 31, 10:22 PM
Unknown Object (File)
Fri, Aug 28, 2:13 PM
Unknown Object (File)
Fri, Aug 28, 1:21 PM
Unknown Object (File)
Fri, Aug 28, 12:10 PM
View All Files
Subscribers
emaste
imp
rgrimes

Details

Reviewers
brooks
imp
jhb
Commits
rGe1d2967ba630: sys/conf: Support building kasan with gcc on arm64
Summary
  • Remove -mllvm flags that don't exist in gcc
  • Set the shadow offset with -fasan-shadow-offset

This allows the arm64 GENERIC-KASAN kernel to build with gcc13.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.May 22 2024, 2:35 PM
Herald added subscribers: rgrimes, emaste, imp. · View Herald TranscriptMay 22 2024, 2:35 PM
andrew requested review of this revision.May 22 2024, 2:35 PM
Harbormaster completed remote builds in B57844: Diff 138922.May 22 2024, 2:35 PM
andrew added a child revision: D45301: arm64: Disable outling atomics.May 22 2024, 2:35 PM
andrew added reviewers: brooks, imp, jhb.Jun 3 2024, 3:49 PM
brooks added a comment.Jun 3 2024, 5:29 PM

I wonder if we want a CFLAGS_GEN=${CFLAGS:N-flto*:N-fno-common:N-fsanitize*:N-fno-sanitize*:N-fasan-shadow-offset*} or maybe a CFLAGS_NOSAN in kern.pre.mk so we're not having to remove arguments in so many places?

andrew updated this revision to Diff 139508.Jun 5 2024, 1:03 PM

Rebase on D45498

Harbormaster completed remote builds in B58065: Diff 139508.Jun 5 2024, 1:03 PM
andrew added a parent revision: D45498: sys/conf: Introduce NOSAN_CFLAGS and NOSAN_C.Jun 5 2024, 1:03 PM
andrew edited the summary of this revision. (Show Details)Jun 5 2024, 1:15 PM
brooks accepted this revision.Jun 5 2024, 4:51 PM
This revision is now accepted and ready to land.Jun 5 2024, 4:51 PM
Closed by commit rGe1d2967ba630: sys/conf: Support building kasan with gcc on arm64 (authored by andrew). · Explain WhyOct 15 2024, 5:25 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rGe1d2967ba630: sys/conf: Support building kasan with gcc on arm64.

Revision Contents
Changeset List

PathSize
sys/
conf/
10 lines

Diff 144936

View Options

sys/conf/kern.pre.mk

Loading...