ofw: Add a ofw_firmware driver
ClosedPublic
Actions

Authored by manu on Dec 6 2022, 11:01 AM.

Details

Reviewers

br
andrew
bz

Group Reviewers

ARM
arm64

Commits

rGfdfd3a90b6ce: ofw: Add a ofw_firmware driver

Summary

Some SoCs have an external firmware doing power management, clock
and other stuffs. (Xilinx, ARM Juno etc ...)
The way it is represent in the DTB is usually having a 'firmware' node
under the root node and have some nodes under it with the correct
compatible strings.
The firmware node itself doesn't have any compatible strings.
This driver is simple subclassed from simplebus and attaches at
BUS_PASS_BUS + BUS_PASS_ORDER_MIDDLE so early drivers (like clock drivers)
can still have a change to attach early.

Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 48621
Build 45507: arc lint + arc unit

Event Timeline

manu created this revision.Dec 6 2022, 11:01 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 6 2022, 11:01 AM

manu requested review of this revision.Dec 6 2022, 11:01 AM

Harbormaster completed remote builds in B48621: Diff 113866.Dec 6 2022, 11:02 AM

manu added reviewers: ARM, arm64, br.Dec 6 2022, 11:02 AM

manu mentioned this in D37316: SCMI support.

manu added a child revision: D37613: arm64: intel: Remove firmware driver.Dec 6 2022, 11:09 AM

Seems to work fine on ARM Morello:

ofw_firmware0: <OFW Firmware Group> on ofwbus0
scmi0: <ARM SCMI interface driver> on ofw_firmware0

andrew accepted this revision.Jun 7 2023, 10:40 AM

This revision is now accepted and ready to land.Jun 7 2023, 10:40 AM

bz requested changes to this revision.Jun 7 2023, 7:02 PM

bz added a subscriber: bz.

bz added inline comments.

sys/dev/ofw/ofw_firmware.c
78	Can't we save *di ourselves given it's always constant NULL (and probably the other 3 constant arguments too)? And that'll simplify ofw_firmware_setup_dinfo() as well. Given they are static, is there any other usage of them envisioned to keep them as are?