xen/timer: make xen timer optional
ClosedPublic
Actions

Authored by ehem_freebsd_m5p.com on Mar 3 2021, 4:33 PM.

Details

Reviewers

royger
mhorne

Commits

rGae5981274815: xen/timer: make xen timer optional

Summary

The timer is not used on ARM.

Adapted-to-HEAD-by: Elliott Mitchell <ehem+freebsd@m5p.com>

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38074
Build 34963: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.Mar 3 2021, 4:33 PM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptMar 3 2021, 4:33 PM

ehem_freebsd_m5p.com requested review of this revision.Mar 3 2021, 4:33 PM

Harbormaster completed remote builds in B37541: Diff 85059.Mar 3 2021, 4:33 PM

ehem_freebsd_m5p.com added reviewers: royger, mhorne.Mar 3 2021, 6:02 PM

ehem_freebsd_m5p.com changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.

Some minor comments.

sys/amd64/conf/GENERIC
383–384	I don't think XENHVM strictly depends on xentimer (as it does on xenpci). It's the other way around, xentimer depends on XENHVM, but you should be able to build a kernel with XENHVM but without xentimer.
387	Could you please append a comment with 'Xen x86 PV timer device' , like it's done for the other lines?

Getting one of the adjustments in.

Harbormaster completed remote builds in B37580: Diff 85150.Mar 4 2021, 5:33 PM

The one comment is done. Thinking about the wording for the other a bit more. The comment came from Julien Grall's original patch, so I can believe time having changed things or the original thinking being mistaken.

ehem_freebsd_m5p.com added inline comments.Mar 19 2021, 9:41 PM

sys/amd64/conf/GENERIC
383–384	I don't think XENHVM strictly depends on xentimer (as it does on xenpci). It's the other way around, xentimer depends on XENHVM, but you should be able to build a kernel with XENHVM but without xentimer. Could I have some certainty here? Does an x86 kernel built with XENHVM, but xentimer disabled boot successfully?

royger added inline comments.Mar 25 2021, 4:04 PM

sys/amd64/conf/GENERIC
383–384	Yes, it will just use another timer, there are plenty on HVM guests, and on PVH it should resort to the local APIC timer.

Adjust comment along proposed line. Hopefully this language works.

Harbormaster completed remote builds in B38074: Diff 86321.Mar 25 2021, 10:15 PM

ehem_freebsd_m5p.com added a subscriber: julien_xen.org.Mar 30 2021, 6:48 PM

royger accepted this revision.Apr 6 2021, 9:27 AM

This revision is now accepted and ready to land.Apr 6 2021, 9:27 AM

ehem_freebsd_m5p.com added a parent revision: D29500: xen/intr: use struct xenisrc * as xen_intr_handle_t.May 13 2021, 11:02 PM

ehem_freebsd_m5p.com added a child revision: D29499: xen/intr: use __func__ instead of function names.

ehem_freebsd_m5p.com added a child revision: D30950: xen/arm64: enable arm64 Xen configuration.Jun 30 2021, 1:28 AM

ehem_freebsd_m5p.com added a child revision: D29304: xen/xenpv: remove low memory limit for non-x86.Jul 3 2021, 5:50 AM

royger added inline comments.Jul 28 2021, 3:21 PM

sys/conf/files
3545	I've slightly changed this to make it depend on both xentimer and xenhvm (since trying to build the timer without the rest of xenhvm won't work anyway).