LinuxKPI: implement devres() framework parts and two examples
ClosedPublic
Actions

Authored by bz on Jan 15 2021, 11:58 PM.

Details

Reviewers

manu
• hselasky

Group Reviewers

linuxkpi

Commits

rGff119f7c4a38: LinuxKPI: implement devres() framework parts and two examples
rGfa765ca73e55: LinuxKPI: implement devres() framework parts and two examples

Summary

LinuxKPI: implement devres() framework parts and two examples

This code implements a version of the devres framework found
working for various iwlwifi use cases and also providing functions
for ttm_page_alloc_dma.c from DRM.

Part of the framework replicates the consumed KPI, while others
are internal helper functions (currently listed in devices.h but
we may wonder if in the future we might have "private" header files
in src/ as well?) or the "release" functions.

In addition the simple devm_k*malloc() consumers were implemented
and kvasprintf() was enhanced to work also for the devm_kasprintf()
case.
Addmittingly lkpi_devm_kmalloc_release() could be avoided but for
the overall understanding of the code and possible memory tracing
it may still be helpful.

Further devsres consumer are implemented for iwlwifi but will follow
later as the main reason for this change is to sort out overlap with
DRM.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36281
Build 33170: arc lint + arc unit

Event Timeline

bz created this revision.Jan 15 2021, 11:58 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 15 2021, 11:58 PM

bz requested review of this revision.Jan 15 2021, 11:58 PM

Harbormaster completed remote builds in B36252: Diff 82349.Jan 15 2021, 11:58 PM

bz added a parent revision: D26598: linuxkpi: upstream drm-kmod conflicting changes.Jan 15 2021, 11:59 PM

• hselasky added inline comments.Jan 16 2021, 9:50 AM

sys/compat/linuxkpi/common/src/linux_compat.c
260	Could you put this new functions in an own .c file? Else your changes look good.

bz added inline comments.Jan 16 2021, 10:59 AM

sys/compat/linuxkpi/common/src/linux_compat.c
260	I can. two questions: (1) Should we name new files linuxkpi_ or lkpi_ instead of linux_ ? (2) Can we have header files in common/src/ next to the implementations to put "internal" function declarations etc. in there which don't have to be publicly visible to the "Linux KPI consumers"?

I can. two questions:

(1) Should we name new files linuxkpi_ or lkpi_ instead of linux_ ?

linux_devm.c is the style for now. Maybe later, if it is needed we can rename all .c files in there.
Don't forget to update sys/conf/files and sys/modules/linuxkpi/Makefile .

(2) Can we have header files in common/src/ next to the implementations to put "internal" function declarations etc. in there which don't have to be publicly visible to the "Linux KPI consumers"?

Yes, you can, or just in the .c -file if it is very internal.

--HPS

Moved devres framework and k*alloc release function into its own implementation
file as requested. For now leave headers as they are; may reconsider when
bringing in more devres consumers.

bz marked an inline comment as done.Jan 16 2021, 9:49 PM

Harbormaster completed remote builds in B36281: Diff 82388.Jan 16 2021, 9:49 PM

• hselasky accepted this revision.Jan 18 2021, 8:30 AM

This revision is now accepted and ready to land.Jan 18 2021, 8:30 AM

LGTM.
Can you provide a merge request on freebsd/drm-kmod before commiting please ?
I'll adapt the __FreeBSD_version change, if any.

Closed by commit rGfa765ca73e55: LinuxKPI: implement devres() framework parts and two examples (authored by bz). · Explain WhyJan 28 2021, 4:48 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rGfa765ca73e55: LinuxKPI: implement devres() framework parts and two examples.

bz added a commit: rGff119f7c4a38: LinuxKPI: implement devres() framework parts and two examples.Feb 2 2021, 12:03 PM