Page MenuHomeFreeBSD
Differential D47732

sound: Merge ac97 and ac97_patch
ClosedPublic
Actions

Authored by christos on Nov 25 2024, 2:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 20, 12:42 PM
Unknown Object (File)
Sat, Oct 18, 5:09 AM
Unknown Object (File)
Sep 18 2025, 12:33 AM
Unknown Object (File)
Sep 17 2025, 12:44 AM
Unknown Object (File)
Aug 3 2025, 8:00 AM
Unknown Object (File)
Jun 23 2025, 9:50 PM
Unknown Object (File)
Jun 23 2025, 3:03 AM
Unknown Object (File)
Jun 21 2025, 4:44 PM
View All 38 Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rG01f650cb8d03: sound: Merge ac97 and ac97_patch
rG0b4e32912566: sound: Merge ac97 and ac97_patch
Summary

No functional change intended.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60754
Build 57638: arc lint + arc unit

Event Timeline

christos created this revision.Nov 25 2024, 2:06 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 25 2024, 2:06 PM
christos requested review of this revision.Nov 25 2024, 2:06 PM
Harbormaster completed remote builds in B60754: Diff 146905.Nov 25 2024, 2:06 PM
markj accepted this revision.Nov 25 2024, 8:29 PM
markj added inline comments.
sys/dev/sound/pcm/ac97.c
882

It'd be nice to fix style while here, i.e., add a newline after static void.

This revision is now accepted and ready to land.Nov 25 2024, 8:29 PM
christos marked an inline comment as done.Nov 25 2024, 9:22 PM
christos added inline comments.
sys/dev/sound/pcm/ac97.c
882

Done. Also fixed the pointer notation: struct ac97_info* codec -> struct ac97_info *codec.

christos marked an inline comment as done.Nov 27 2024, 3:53 PM
Closed by commit rG0b4e32912566: sound: Merge ac97 and ac97_patch (authored by christos). · Explain WhyDec 2 2024, 4:27 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG0b4e32912566: sound: Merge ac97 and ac97_patch.
christos added a commit: rG01f650cb8d03: sound: Merge ac97 and ac97_patch.Dec 4 2024, 12:04 PM

Revision Contents
Changeset List

PathSize
sys/
conf/
1 line
dev/
sound/
pcm/
91 lines
modules/
sound/
sound/
2 lines

Diff 146905

View Options

sys/conf/files

Loading...
View Options

sys/dev/sound/pcm/ac97.c

Loading...
View Options

sys/dev/sound/pcm/ac97_patch.h

Loading...
View Options

sys/dev/sound/pcm/ac97_patch.c

Loading...
View Options

sys/modules/sound/sound/Makefile

Loading...