conf: deduplicate dwc config logic
ClosedPublic
Actions

Authored by mhorne on Feb 27 2024, 5:57 PM.

Details

Reviewers

manu
andrew

Group Reviewers

arm64
riscv

Commits

rGa01dc140b27e: conf: deduplicate dwc config logic

Summary

Move the core dwc(4) file entries to the MI conf/files.
Platform-specific versions e.g. rk_dwc are retained in their current
position. On arm64 this necessitates adding an additional 'device dwc'
option.

This hardware is found on several available/emerging RISC-V SoCs, so we
will soon need it on this architecture. Add it to LINT for now.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Feb 27 2024, 5:57 PM

Herald added a reviewer: andrew. · View Herald TranscriptFeb 27 2024, 5:57 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added subscribers: emaste, imp. · View Herald Transcript

mhorne requested review of this revision.Feb 27 2024, 5:57 PM

Harbormaster completed remote builds in B56276: Diff 135082.Feb 27 2024, 5:57 PM

jrtc27 added a subscriber: jrtc27.Feb 27 2024, 6:03 PM

jrtc27 added inline comments.

sys/riscv/conf/NOTES
61 ↗	(On Diff #135082)	This seems like a separate change?

mhorne added inline comments.Feb 27 2024, 6:09 PM

sys/riscv/conf/NOTES
61 ↗	(On Diff #135082)	Yeah, you are right. I will split this out before commit, same goes for dwmmc addition in D44104.

jrtc27 added inline comments.Feb 27 2024, 6:10 PM

sys/riscv/conf/NOTES
61 ↗	(On Diff #135082)	Ok. I think it's fine to merge the two riscv dwc* changes into one commit though if you want to, though commits are cheap.

manu accepted this revision.Feb 27 2024, 6:16 PM

This revision is now accepted and ready to land.Feb 27 2024, 6:16 PM

Closed by commit rGa01dc140b27e: conf: deduplicate dwc config logic (authored by mhorne). · Explain WhyFeb 27 2024, 10:11 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rGa01dc140b27e: conf: deduplicate dwc config logic.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

conf/

NOTES

1 line

std.altera

1 line

std.rockchip

1 line

conf/

files

4 lines

files.arm

4 lines

files.arm64

4 lines

Diff 135129

View Options

sys/arm64/conf/NOTES

View Options

sys/arm64/conf/std.altera

View Options

sys/arm64/conf/std.rockchip

View Options

sys/conf/files

View Options

sys/conf/files.arm

View Options

conf: deduplicate dwc config logicClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 135129

sys/arm64/conf/NOTES

sys/arm64/conf/std.altera

sys/arm64/conf/std.rockchip

sys/conf/files

sys/conf/files.arm

sys/conf/files.arm64

conf: deduplicate dwc config logic
ClosedPublic
Actions

Revision Contents
Changeset List