Page MenuHomeFreeBSD
Differential D50605

sound: Retire the MIDI sequencer
Needs ReviewPublic
Actions

Authored by christos on Fri, May 30, 3:30 PM.
Tags
None
Referenced Files
F119671581: D50605.id156299.diff
Wed, Jun 11, 3:30 AM
Unknown Object (File)
Sun, Jun 8, 3:29 PM
Unknown Object (File)
Sat, Jun 7, 6:27 PM
Unknown Object (File)
Sat, Jun 7, 5:36 PM
Unknown Object (File)
Wed, Jun 4, 11:16 PM
Unknown Object (File)
Wed, Jun 4, 4:21 PM
Unknown Object (File)
Wed, Jun 4, 12:25 PM
Unknown Object (File)
Tue, Jun 3, 6:40 AM
Subscribers
imp
ivy

Details

Reviewers
markj
emaste
adrian
vishwin
Summary

The in-kernel MIDI sequencer is not used anymore, since this is done by
userland applications nowadays. It also contains bugs, and we are not
exactly sure how it works, or if it worked properly in the first place.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64552
Build 61436: arc lint + arc unit

Event Timeline

christos created this revision.Fri, May 30, 3:30 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, May 30, 3:30 PM
christos requested review of this revision.Fri, May 30, 3:30 PM
Harbormaster completed remote builds in B64548: Diff 156299.Fri, May 30, 3:30 PM
ivy added a subscriber: ivy.Fri, May 30, 3:32 PM
christos updated this revision to Diff 156304.Fri, May 30, 3:51 PM

Remove some more stuff from midi.c

Harbormaster completed remote builds in B64552: Diff 156304.Fri, May 30, 3:51 PM
markj added a comment.Sun, Jun 1, 8:50 PM

Does this removal warrant some post on -current or so to make sure no one's using it?

christos added a comment.Mon, Jun 2, 4:52 PM
In D50605#1155981, @markj wrote:

Does this removal warrant some post on -current or so to make sure no one's using it?

I've already sent an email to -multimedia and no one said they, or a port, is using it, but I can send to -current as well.

christos added a comment.Wed, Jun 4, 4:22 PM
In D50605#1155981, @markj wrote:

Does this removal warrant some post on -current or so to make sure no one's using it?

https://lists.freebsd.org/archives/freebsd-current/2025-June/007797.html

christos added a reviewer: vishwin.Wed, Jun 11, 5:12 PM

Revision Contents
Changeset List

PathSize
sys/
conf/
1 line
dev/
sound/
midi/
1 line
14 lines
pcm/
3 lines
1 line
modules/
sound/
sound/
2 lines

Diff 156304

View Options

sys/conf/files

Loading...
View Options

sys/dev/sound/midi/midi.h

Loading...
View Options

sys/dev/sound/midi/midi.c

Loading...
View Options

sys/dev/sound/midi/sequencer.h

Loading...
View Options

sys/dev/sound/midi/sequencer.c

Loading...
View Options

sys/dev/sound/pcm/sndstat.c

Loading...
View Options

sys/dev/sound/pcm/sound.h

Loading...
View Options

sys/modules/sound/sound/Makefile

Loading...