Page MenuHomeFreeBSD
Differential D52909

sys: move sys/kern/md[45].c to sys/crypto
ClosedPublic
Actions

Authored by fuz on Oct 4 2025, 9:47 PM.
Tags
None
Referenced Files
F139451378: D52909.diff
Fri, Dec 12, 6:11 AM
Unknown Object (File)
Sun, Dec 7, 6:32 AM
Unknown Object (File)
Sun, Nov 23, 8:07 PM
Unknown Object (File)
Tue, Nov 18, 7:26 PM
Unknown Object (File)
Nov 8 2025, 5:38 PM
Unknown Object (File)
Nov 7 2025, 11:49 AM
Unknown Object (File)
Nov 3 2025, 3:54 AM
Unknown Object (File)
Nov 1 2025, 1:58 AM
View All 28 Files
Subscribers
dab
olce

Details

Reviewers
markj
imp
manu
Commits
rG5a566616e662: sys: move sys/kern/md[45].c to sys/crypto
rG73a9b273d3d3: sys: move sys/kern/md[45].c to sys/crypto
Summary

Both files are used by kernel and userspace.
Move them to sys/crypto where they belong.

No functional changes intended.

In preparation of D45670.

Test Plan

builds fine

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 67560
Build 64443: arc lint + arc unit

Event Timeline

fuz created this revision.Oct 4 2025, 9:47 PM
Herald added a reviewer: manu. · View Herald TranscriptOct 4 2025, 9:47 PM
Herald added subscribers: olce, dab. · View Herald Transcript
fuz requested review of this revision.Oct 4 2025, 9:47 PM
Harbormaster completed remote builds in B67560: Diff 163567.Oct 4 2025, 9:47 PM
fuz added a parent revision: D52784: libc/resolv: get rid of MD5.Oct 4 2025, 9:50 PM
fuz added a child revision: D45670: lib/libmd: reimplement and enhance md5.
markj accepted this revision.Oct 7 2025, 7:11 PM
markj added inline comments.
stand/libsa/Makefile
192

I'd remove this comment too, it's not useful.

This revision is now accepted and ready to land.Oct 7 2025, 7:11 PM
fuz added a comment.Oct 7 2025, 7:19 PM

Will do. I had to stop with the MD5 changeset as I noticed a performance regression on AMD Zen 4, which I will have to look into in more detail.

fuz mentioned this in D45670: lib/libmd: reimplement and enhance md5.Oct 10 2025, 8:12 PM
Closed by commit rG73a9b273d3d3: sys: move sys/kern/md[45].c to sys/crypto (authored by fuz). · Explain WhyOct 24 2025, 10:19 AM
This revision was automatically updated to reflect the committed changes.
fuz added a commit: rG73a9b273d3d3: sys: move sys/kern/md[45].c to sys/crypto.
fuz added a commit: rG5a566616e662: sys: move sys/kern/md[45].c to sys/crypto.Sun, Nov 23, 9:45 AM

Revision Contents
Changeset List

PathSize
lib/
libmd/
2 lines
stand/
libsa/
2 lines
sys/
conf/
4 lines
crypto/
kern/
298 lines
341 lines
kern/
modules/
smbfs/
4 lines

Diff 163567

View Options

lib/libmd/Makefile

Loading...
View Options

stand/libsa/Makefile

Loading...
View Options

sys/conf/files

Loading...
View Options

sys/crypto/md4c.c

Loading...
View Options

sys/crypto/md5c.c

Loading...
View Options

sys/kern/md4c.c

Loading...
View Options

sys/kern/md5c.c

Loading...
View Options

sys/modules/smbfs/Makefile

Loading...