Page MenuHomeFreeBSD

lib/geom: remove redundant libraries and objects
ClosedPublic

Authored by fuz on Fri, Oct 11, 2:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 15, 11:50 AM
Unknown Object (File)
Sun, Oct 13, 1:28 AM
Subscribers

Details

Summary

Do not link lib/geom/raid with libmd, it is not required for the module.
Do not include the sha256/sha512 code in lib/geom/eli, it is provided by
libmd. Remove ${.CURDIR:H:H}/misc from .PATH for all modules. This
path has stopped being valid when the GEOM modules were moved from
sbin/geom to lib/geom.

Test Plan

no functional changes, builds fine.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fuz requested review of this revision.Fri, Oct 11, 2:58 PM
emaste added inline comments.
lib/geom/eli/Makefile
9–10

This appeared in 7a3f5d11fb3873674a1f7e27bcc9a5f7ce279390, replacing SRCS+= sha2.c. That came from c58794debd2bf. libmd was added in fd833a6a190f8 without removing sha2.c. So it looks to me like this just fell through the cracks.

lib/geom/raid/Makefile
6

This was added at the beginning of geom/raid in 89b172238a5db, MFgraid/head.

This revision is now accepted and ready to land.Fri, Oct 11, 3:12 PM