Paths

Table of Contentst

Differential D51992

virtio/mmio: Remove the unused virtio_mmio_if.m
ClosedPublic
Actions

Authored by andrew on Aug 18 2025, 9:57 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, May 19, 8:34 PM

	Unknown Object (File)
	Mon, May 18, 1:52 AM

	Unknown Object (File)
	Sun, May 17, 8:44 PM

	Unknown Object (File)
	Fri, May 15, 4:15 AM

	Unknown Object (File)
	Tue, May 12, 11:35 PM

	Unknown Object (File)
	Sun, May 10, 3:04 AM

	Unknown Object (File)
	Sun, May 10, 3:01 AM

	Unknown Object (File)
	Sat, May 9, 9:25 PM

View All 78 Files

Subscribers

Details

Reviewers

br
imp

Commits

rG4740d47238cf: virtio/mmio: Remove the unused virtio_mmio_if.m

Summary

The only driver I know that implemented this interface was removed 7
months ago. Remove the interface and platform from the softc.

Sponsored by: Arm Ltd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Aug 18 2025, 9:57 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 18 2025, 9:57 AM

andrew requested review of this revision.Aug 18 2025, 9:57 AM

Harbormaster completed remote builds in B66315: Diff 160532.Aug 18 2025, 9:57 AM

andrew added a child revision: D51993: virtio: Remove the unused poll method.Aug 18 2025, 9:57 AM

What was the last driver?

This revision is now accepted and ready to land.Aug 18 2025, 2:28 PM

It was a beri driver in sys/dev/beri/virtio/virtio_mmio_platform.c

jrtc27 added a subscriber: jrtc27.Aug 18 2025, 5:14 PM

jrtc27 added inline comments.

sys/dev/virtio/mmio/virtio_mmio.c
104–109
160	I believe this method is now never implemented? Presumably it was for cache coherence or similar in the dodgy BERI VirtIO world; virtqueue_poll calls it just before virtqueue_dequeue.

andrew added inline comments.Aug 20 2025, 9:16 AM

sys/dev/virtio/mmio/virtio_mmio.c
160	I already removed it in D51993

Closed by commit rG4740d47238cf: virtio/mmio: Remove the unused virtio_mmio_if.m (authored by andrew). · Explain WhyAug 21 2025, 8:44 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG4740d47238cf: virtio/mmio: Remove the unused virtio_mmio_if.m.

Revision Contents
Changeset List

Path

Size

sys/

conf/

1 line

dev/

virtio/

mmio/

1 line

48 lines

virtio_mmio_fdt.c

47 lines

virtio_mmio_if.m

Diff 160714

sys/conf/files

Loading...

sys/dev/virtio/mmio/virtio_mmio.h

Loading...

sys/dev/virtio/mmio/virtio_mmio.c

Loading...

sys/dev/virtio/mmio/virtio_mmio_fdt.c

Loading...

sys/dev/virtio/mmio/virtio_mmio_if.m

Loading...