Thank you!

In D54613#1248261, @guest-seuros wrote:

We could wrap it with a sleep mutex, but concurrent fan control from multiple threads is not a realistic scenario.

The driver uses I2C bus transfers which handle locking internally via the I2C bus layer.

acpi_battery_get_battinfo() calls into the newbus layer and accesses some structures that are synchronized by the Giant lock. I think we need to at least acquire bus_topo_lock() in acpi_battery_get_battinfo().

This works for me too. Feel free to revert the thing I committed.
I gotta work on tagging people better on github reviews

This version of the patch doesn't apply. Something stripped all of the tabs in the file.

In D54615#1248205, @guest-seuros wrote:

This module load only in apple hardware. Spparently the hardware is not build to have it driver hot reloaded.

System boot -> unload driver -> ok -> load it again -> panic (resources were not freed) (need a full reboot)

FreeBSD supports both. For cross-builds, on Linux it is defined as 0, and on macOS it is defined as 1 in their respective nbtool_config.h header files.

Looks ok, but I'd use int in the function signature.

In D54572#1248367, @kib wrote:

In D54572#1248346, @markj wrote:

In D54572#1247713, @kib wrote:

Or give up on the slight over-accounting and charge the whole object unconditionally, as it is done in the patch.

How do we know it is slight? Is there some way to express a bound on the amount of swap that might be wasted due to the over-accounting?

Do you want an exact formula? I do not think it is possible, simply due to the nature of the interaction with the user.

Note this fixes the issue reported in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282237 and with commit 7631790422464de1aec309018e2c444defe5f629 differently, but the fix mirrors what SmartOS/illumos did to minimize diff's between the various bhyve implementations.

Removed files from patch that didn't actually change (just date change from when I ran make makepatch).

Since there was no agreement whether the author's email address should be updated for a newer one, I am going to clone this one.

There is a typo in the commit message: libbbhyve.

There is a typo in the commit message: libbbhyve.

In D54606#1248653, @jrm wrote:

I think the feeling of being ignored is fairly common in the project. There is just more work to be done than time to do it all, and people often expend their energy on things that interest them.

Address style(9) fixes

Apply style(9) fixes

Thanks. At your convenience.

don't fiddle with SUNPATHLEN

In D54606#1248645, @jrm wrote:

@michaelo, I believe I've addressed all your concerns, and I've performed some light testing with manually created logs. Are you able and willing to do any testing with your real logs for the three scripts?

@michaelo, I believe I've addressed all your concerns, and I've performed some light testing with manually created logs. Are you able and willing to do any testing with your real logs for the three scripts?

• Add a space after %e
• Ensure we match what we really want by putting the .* in the grep command and putting the patterns for the alternatives timestamps inside parentheses.
• We now neeed egrep in 900.tcpwrap.

@ngie , it seems we could land it, and copyright topic could be revised for entire project with separate commit(s). What do you think?

Throw std::system_error instead of std::runtime_error upon kldload failure

In D54336#1248598, @arrowd wrote:

Any movement on this?

Any movement on this?

LGTM
also tested:

# kyua test -k /usr/tests/sys/netinet6/Kyuafile ndp
ndp:ndp_add_gu_success  ->  passed  [2.012s]
ndp:ndp_del_gu_success  ->  passed  [3.407s]
ndp:ndp_prefix_len_mismatch  ->  passed  [2.128s]
ndp:ndp_prefix_lifetime  ->  passed  [15.506s]
ndp:ndp_prefix_lifetime_extend  ->  passed  [0.078s]
ndp:ndp_slaac_default_route  ->  passed  [5.364s]

Explicitly describe execenv involvement in "kyua help debug"