I wish I had a list of open revisions that I've approved, and another list of open revisions I've commented on. That would really help.

@kbowling @kgalazka this seems to have been missed

Oops! I forgot about this. Felix has been afk for a few weeks, but he switched his new reviews to his domain lately, I'll use that.

Can you please confirm the author info you want on the commit -- I see Felix Johnson <fjohnson@felix-johnson.com> and Felix Johnson <felix.the.red@gmail.com> in the commit history now.

+ demonstrate some pages use optional values in synopsis
+ use the freebsd macro instead of typing freebsd

In D55077#1259991, @markj wrote:

In D55077#1259978, @tembun_bk.ru wrote:

So should /usr/lib/debug/boot directory itself be included in DEBUG_DIRS?

No, I think it shouldn't. So I guess the proper thing would be to exclude \! -d /usr/lib/debug/boot/* \! -d /usr/lib/debug/boot. Maybe there's a cleaner way to write that.

Alright... try this!

In D55120#1259993, @markj wrote:

In D55120#1259960, @emaste wrote:

It's not necessarily abandoned, this could also be used for patches submitted in non-email contexts, e.g. in a reddit comment.

Or changes that aren't presented with a patch at all, like inline code snippets in a phab review.

Looking at some recent history I see:
Submitted by: Kraytonian -- no idea
Submitted by: markj -- maybe via comments in another review
Submitted by: MOROHOSHI Akihiko <moro@remus.dti.ne.jp> -- sounds like maybe not a patch per se, but a description of a change
Submitted by: lampa@fit.vutbr.cz -- this one looks like a missing use of git --author
Submitted by: Marco Devesas Campos <devesas.campos@gmail.com> -- redundant, git author also set to the same author

Sorry for the delay. I think this is ok.

In D55120#1259960, @emaste wrote:

It's not necessarily abandoned, this could also be used for patches submitted in non-email contexts, e.g. in a reddit comment.

In D55077#1259978, @tembun_bk.ru wrote:

So should /usr/lib/debug/boot directory itself be included in DEBUG_DIRS?

It looks like part of this was committed in 62e1227219f2f79a2ed7a672149dc3d774d25dd4.
Is there remaining work to be committed, or should this be closed?

LGTM. Good find! Approved.

In D54443#1259973, @ae wrote:

Can you take a look at this patch? Maybe you can reuse some pieces, it should fix 275474 and also make access to softc in a safer way.

With respect to the change itself, I do not see why make delete-old should touch anything under /usr/lib/debug/boot. I believe that the intent of the current code is to ignore anything under /usr/lib/debug/boot/*. What exactly is the problem being solved?

Can you take a look at this patch? Maybe you can reuse some pieces, it should fix 275474 and also make access to softc in a safer way.