- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Today
Yesterday
Minor documentation tweak (s/if/when/)
In D48319#1102044, @adrian wrote:So, yeah, let's land this diff, then go fix +vht / -vht to clear/set FVHT_VHT and verify that does the right thing, without having to set/clear all the flags.
I think a good mini project for someone is to turn the HTCONF ioctl bits to actually use defines, not magic numbers. :-)
So, yeah, let's land this diff, then go fix +vht / -vht to clear/set FVHT_VHT and verify that does the right thing, without having to set/clear all the flags.
hm, look at that, those numbers are hilarious.
In D48319#1102010, @adrian wrote:In D48319#1102005, @bz wrote:In D48319#1101982, @adrian wrote:rofl nice catch, wanna land that too? :-)
The question is, should -vht also clear -vht40 -vht80 -vht160 -cht80p80?
It should just disable vht entirely, but it shouldn't need to clear ALL the flags.
The net80211 code should be checking if vht is enabled before checking the channel bandwidths avaliable.I'm /pretty/ sure setting -ht doesn't also clear -ht40 greenfield, etc, it just disables being able to negotiate HT to begin with.
In D48319#1102005, @bz wrote:In D48319#1101982, @adrian wrote:rofl nice catch, wanna land that too? :-)
The question is, should -vht also clear -vht40 -vht80 -vht160 -cht80p80?
Changed != to ^ in write-read-back check.
In D48319#1101982, @adrian wrote:rofl nice catch, wanna land that too? :-)
old code :)
Individual revisions splited from b662ca1d6cd82044c6cb79075e1830b97594bef3 are also on Github. D43236, D43237, and D43239
In D43239#1101984, @jhb wrote:Do you have a branch pushed somewhere with these commits split out already?
Fix td passed for coredumps
Do you have a branch pushed somewhere with these commits split out already?
rofl nice catch, wanna land that too? :-)
In D48319#1101978, @adrian wrote:That /does/ remind me, we should figure out why "ifconfig wlan0 -vht" doesn't work :-)
(ifconfig wlan0 -ht and ifconfig wlan0 ht works though!)
That /does/ remind me, we should figure out why "ifconfig wlan0 -vht" doesn't work :-)
Fix include file patch