In D52443#1197695, @obiwac wrote:

Actually this would need sys/types.h to be included because sysctl.h makes use of u_int and intmax_t. Is it okay to include this?

In D52365#1197605, @arrowd wrote:

I tried building this in Poudriere to rule out environmental differencies and git this:

===>  Building for virtual_oss_sndio-1500053
--- sndio.pico ---
cc -fpic -DPIC   -O2 -pipe  -fstack-protector-strong -fno-strict-aliasing  -fno-common -I/usr/src/usr.sbin/virtual_oss/virtual_oss  -I/usr/local/include   -MD  -MF.depend.sndio.pico -MTsndio.pico -std=gnu17 -Wno-format-zero-length -fstack-protector-strong -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Wnested-externs -Wold-style-definition -Wno-pointer-sign -Wdate-time -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-error=unused-but-set-parameter -Wno-error=cast-function-type-mismatch  -Qunused-arguments      -c /usr/src/lib/virtual_oss/sndio/sndio.c -o sndio.pico
In file included from /usr/src/lib/virtual_oss/sndio/sndio.c:36:
/usr/src/usr.sbin/virtual_oss/virtual_oss/int.h:33:10: fatal error: 'samplerate.h' file not found
   33 | #include <samplerate.h>
      |          ^~~~~~~~~~~~~~
1 error generated.
*** [sndio.pico] Error code 1

I took the freshest revision of D52308, of course.

Build sndio backend with libsamplerate to address build failure in
https://reviews.freebsd.org/D52365#1197605.

Actually this would need sys/types.h to be included because sysctl.h makes use of u_int and intmax_t. Is it okay to include this?

Return actual errno values in other code paths.

The BIOS loader uses -Wall, but I'm not sure about the rest.

Ah, I don't mind. :)

Approved.

Friendly ping.

A bit of more research: this is what Linux does

TBH, I would like to see whole loader being built with -Wall (and -Wextra;)

If you do not mind to do extra work, the function is supposed to return 0 or error code, could you replace the return(1) lines above with return (efi_status_to_errno(status)) or like:)

Good catch:)

I tried building this in Poudriere to rule out environmental differencies and git this:

===>  Building for virtual_oss_sndio-1500053
--- sndio.pico ---
cc -fpic -DPIC   -O2 -pipe  -fstack-protector-strong -fno-strict-aliasing  -fno-common -I/usr/src/usr.sbin/virtual_oss/virtual_oss  -I/usr/local/include   -MD  -MF.depend.sndio.pico -MTsndio.pico -std=gnu17 -Wno-format-zero-length -fstack-protector-strong -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Wnested-externs -Wold-style-definition -Wno-pointer-sign -Wdate-time -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-error=unused-but-set-parameter -Wno-error=cast-function-type-mismatch  -Qunused-arguments      -c /usr/src/lib/virtual_oss/sndio/sndio.c -o sndio.pico
In file included from /usr/src/lib/virtual_oss/sndio/sndio.c:36:
/usr/src/usr.sbin/virtual_oss/virtual_oss/int.h:33:10: fatal error: 'samplerate.h' file not found
   33 | #include <samplerate.h>
      |          ^~~~~~~~~~~~~~
1 error generated.
*** [sndio.pico] Error code 1

I took the freshest revision of D52308, of course.

• Set mode of etc directory to 0750

• Set mode of sudoers directory to 0750

In D50995#1164515, @bz wrote:

Lastly contrib/llvm-project/libcxx/include/__bit/popcount.h says:

"__builtin_popcountg is available since Clang 19 and GCC 14"

No idea what our bare minimum is.

I expected the timeout handling to be in the CAM, but it seems the CAM only performs a retry and does not execute cmd abort and controller reset. Therefore, I implemented the cmd abort and controller reset within the ufshci driver. Is my understanding correct?

Added some comments for reviewers.

fix indent