That's ok for me, but I thought that things work by default.

In D54253#1239650, @pkubaj wrote:

The real problem is mentioned here: https://wiki.freebsd.org/BjoernZeeb/Ten64

If loaded as module from multi-user we do not get the time set even if manually triggering a sysctl debug.clock_do_io=1. Reason for this is that vfs_moutroot() is responsible to have the clock set and calls CLOCK_GETTIME() indirectly so that log files or other timestamps do not appear to go backwards (if no RTC is found it'll use the vfs root node date?). Look for the inittodr() call.

The real problem is mentioned here: https://wiki.freebsd.org/BjoernZeeb/Ten64

If loaded as module from multi-user we do not get the time set even if manually triggering a sysctl debug.clock_do_io=1. Reason for this is that vfs_moutroot() is responsible to have the clock set and calls CLOCK_GETTIME() indirectly so that log files or other timestamps do not appear to go backwards (if no RTC is found it'll use the vfs root node date?). Look for the inittodr() call.

That's clearly not the way to go, finding the real problem is what you need to do.

Also unless we are fixing the instructions, you should follow the documented project policy and use the preferred license for new files. This is an ISO standard, many other major projects have done the same thing including the Linux kernel, and there is absolutely zero point in making everyone scroll past the same text for the millionth time.

D54231: libusb20_dev_open(3) and libusb20_be_device_foreach(3) man pages.
lint fix (need clarity on library)

Wow, this is cool! Can we have a manual? Even just a skeleton makes this so much more discoverable, like I did here:

Address review comments:

• place .for at line beginning.
• use LOCALBASE to invoke jpm.
• update pkg-descr

D54218: Introduce libusb20_dev_open_with_flags for exclusive access.
libusb20_dev_open is exclusive. Use libusb20_dev_open_with_flags for shared access.
This makes the unit test matrix simpler and is easier to document since libusb_dev_open already returns LIBUSB20_ERROR_BUSY to two calls to open the same libusb20_device pointer.

Done! What next?

D54231: libusb20_dev_open(3) and libusb20_be_device_foreach(3) man pages.
USB access library

In D53953#1235126, @kevans wrote:

Highlights:
(snip)

i've added this patch to my local ppc64le build and haven't noticed any problems so far, but i'm not really qualified to say if it's actually correct or not. (that said, i tend to agree that if we actually need to cache flush here, this seems like an ABI issue that needs to be fixed elsewhere.)

I've no doubt now that MIDI will work, although my set if patches is slightly different from yours, but please make incremental patches over this one, so we can see what is changed!

I suggest you to commit D54129 so that we can make proper tests and incremental changes over it more simply.

Fix pend (and eliminate).

I see. You may only have to check for M_RX inside the loop and not at line 433 (file closed), in addition to the extra lock/unlock.

Maxim made the same fix 15 minutes earlier.

Some more nits. I am still thinking if we want to move to standalone manual pages, or extend the current libusb20(3). We can also add .Sh EXAMPLES to libusb20(3).

Ok, if somebody from the powerpc crowd confirm that the isync is redundant there, I am fine with that.
If not, I put a sketch for my proposal at D54246.

Not even compiled.

Maxim K. commited the fix. I've sent an email to phabric-admin@freebsd.org requesting this review be abandoned.