Page MenuHomeFreeBSD
Differential D50499

kyua: increase cleanup_timeout to 300s
ClosedPublic
Actions

Authored by ivy on May 23 2025, 8:11 PM.
Tags
None
Referenced Files
F133622954: D50499.id156516.diff
Mon, Oct 27, 2:30 AM
Unknown Object (File)
Sun, Oct 26, 10:26 PM
Unknown Object (File)
Sat, Oct 25, 5:01 AM
Unknown Object (File)
Sep 24 2025, 3:52 AM
Unknown Object (File)
Sep 21 2025, 8:57 PM
Unknown Object (File)
Sep 17 2025, 7:58 AM
Unknown Object (File)
Sep 8 2025, 8:58 AM
Unknown Object (File)
Aug 20 2025, 4:32 AM
View All 51 Files
Subscribers
imp
ngie

Details

Reviewers
des
kevans
kp
igoro
Group Reviewers
tests
Commits
rGbc6ec9642b5a: kyua: increase cleanup_timeout to 300s
rG0e33211f911c: kyua: increase cleanup_timeout to 300s
Summary

Test cleanup times out after 60 seconds, causing the test to fail if the
cleanup hasn't finished in time. This timeout should be configurable,
but it currently is not.

Several tests (e.g. bridge, pf) are now reaching this limit; as a
workaround, increase the timeout to 300 seconds.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivy created this revision.May 23 2025, 8:11 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 23 2025, 8:11 PM
ivy requested review of this revision.May 23 2025, 8:11 PM
Harbormaster completed remote builds in B64393: Diff 155945.May 23 2025, 8:12 PM
ivy added a child revision: D50476: tests/sys/net: run if_bridge_test in a jail.May 23 2025, 8:12 PM
des accepted this revision.May 23 2025, 9:02 PM
des added a subscriber: ngie.

kinda ironic that you had five minutes to list your tests, but only 60 seconds to clean up after running one...

lgtm, but please give @ngie or someone else from tests a reasonable chance to object.

This revision is now accepted and ready to land.May 23 2025, 9:02 PM
ivy mentioned this in D50476: tests/sys/net: run if_bridge_test in a jail.May 23 2025, 9:44 PM
ivy added a reviewer: igoro.
igoro accepted this revision as: igoro.May 24 2025, 11:28 AM
kevans accepted this revision as: kevans.Jun 4 2025, 4:00 AM

Please upstream this to github:freebsd/kyua as well, though I think it's fine to land it here first.

Closed by commit rG0e33211f911c: kyua: increase cleanup_timeout to 300s (authored by ivy). · Explain WhyJun 4 2025, 6:23 AM
This revision was automatically updated to reflect the committed changes.
ivy added a commit: rG0e33211f911c: kyua: increase cleanup_timeout to 300s.
ivy added a commit: rGbc6ec9642b5a: kyua: increase cleanup_timeout to 300s.Jun 29 2025, 9:00 PM

Revision Contents
Changeset List

PathSize
contrib/
kyua/
engine/
4 lines

Diff 156516

View Options

contrib/kyua/engine/scheduler.cpp

Loading...