kdump: nicer printing of kill(2) PID argument
ClosedPublic
Actions

Authored by kevans on Sat, May 24, 4:14 AM.

Details

Reviewers

jhb
markj
olce

Commits

rG969f6380eb66: kdump: nicer printing of kill(2) PID argument

Summary

Similar to wait*(), kill(2) operates on a pid that currently gets output
as hex. Output it in decimal to make it a little easier to eyeball the
pid we're signalling.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Sat, May 24, 4:14 AM

Herald added a subscriber: imp. · View Herald TranscriptSat, May 24, 4:14 AM

kevans requested review of this revision.Sat, May 24, 4:14 AM

Harbormaster completed remote builds in B64405: Diff 155968.Sat, May 24, 4:14 AM

kevans added a parent revision: D50496: kdump: nicer printing of wait*() ID arguments.Sat, May 24, 4:15 AM

markj added inline comments.Sat, May 24, 1:14 PM

usr.bin/kdump/kdump.c
1031–1032	What exactly does this assignment do? Do we handle negative PID arguments correctly here?

kevans added inline comments.Sat, May 24, 1:37 PM

usr.bin/kdump/kdump.c
1031–1032	Forces the sign extension that I tried to manually hand-roll in wait4 so that it gets interpreted correctly.

markj accepted this revision.Sat, May 24, 1:48 PM

This revision is now accepted and ready to land.Sat, May 24, 1:48 PM

Closed by commit rG969f6380eb66: kdump: nicer printing of kill(2) PID argument (authored by kevans). · Explain WhyWed, Jun 4, 1:51 AM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rG969f6380eb66: kdump: nicer printing of kill(2) PID argument.

Revision Contents
Changeset List

Path

Size

usr.bin/

kdump/

kdump.c

3 lines

Diff 156509

View Options

kdump: nicer printing of kill(2) PID argumentClosedPublicActions