Page MenuHomeFreeBSD
Differential D50496

kdump: nicer printing of wait*() ID arguments
AcceptedPublic
Actions

Authored by kevans on Fri, May 23, 6:04 PM.
Tags
None
Referenced Files
F118964819: D50496.diff
Tue, Jun 3, 8:35 PM
F118960773: D50496.diff
Tue, Jun 3, 7:33 PM
Unknown Object (File)
Sat, May 31, 4:39 PM
Unknown Object (File)
Thu, May 29, 10:56 AM
Unknown Object (File)
Tue, May 27, 9:15 AM
Subscribers
imp

Details

Reviewers
jhb
markj
olce
Summary

Currently, both of these will print pid/uid/gid/sid/jid in hex, which
isn't very helpful for eyeballing. Align more closely with truss(1) and
print these in decimal instead. ip is likely wider than our ID type,
so we coerce -1 properly in wait4(2) to get it to render properly.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64385
Build 61269: arc lint + arc unit

Event Timeline

kevans created this revision.Fri, May 23, 6:04 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, May 23, 6:04 PM
kevans requested review of this revision.Fri, May 23, 6:04 PM
Harbormaster completed remote builds in B64385: Diff 155935.Fri, May 23, 6:04 PM
markj accepted this revision.Sat, May 24, 1:22 AM

It might be nice to apply similar handling to kill(2), since the first argument there can also be negative.

This revision is now accepted and ready to land.Sat, May 24, 1:22 AM
kevans added a comment.Sat, May 24, 2:05 AM
In D50496#1152747, @markj wrote:

It might be nice to apply similar handling to kill(2), since the first argument there can also be negative.

Good point, will stage that next. I went with *ip = (pid_t)*ip there, which I think I like better as a pattern than the special case for -1 here... I think I'll switch wait 4 to it pre-commit.

kevans added a child revision: D50508: kdump: nicer printing of kill(2) PID argument.Sat, May 24, 4:15 AM

Revision Contents
Changeset List

PathSize
usr.bin/
kdump/
6 lines

Diff 155935

View Options

usr.bin/kdump/kdump.c

Loading...