kdump: nicer printing of wait*() ID arguments
ClosedPublic
Actions

Authored by kevans on May 23 2025, 6:04 PM.

Details

Reviewers

jhb
markj
olce

Commits

rG3eb26ef41ce8: kdump: nicer printing of wait*() ID arguments

Summary

Currently, both of these will print pid/uid/gid/sid/jid in hex, which
isn't very helpful for eyeballing. Align more closely with truss(1) and
print these in decimal instead. ip is likely wider than our ID type,
so we coerce -1 properly in wait4(2) to get it to render properly.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.May 23 2025, 6:04 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 23 2025, 6:04 PM

kevans requested review of this revision.May 23 2025, 6:04 PM

Harbormaster completed remote builds in B64385: Diff 155935.May 23 2025, 6:04 PM

It might be nice to apply similar handling to kill(2), since the first argument there can also be negative.

This revision is now accepted and ready to land.May 24 2025, 1:22 AM

In D50496#1152747, @markj wrote:

It might be nice to apply similar handling to kill(2), since the first argument there can also be negative.

Good point, will stage that next. I went with *ip = (pid_t)*ip there, which I think I like better as a pattern than the special case for -1 here... I think I'll switch wait 4 to it pre-commit.

kevans added a child revision: D50508: kdump: nicer printing of kill(2) PID argument.May 24 2025, 4:15 AM

Closed by commit rG3eb26ef41ce8: kdump: nicer printing of wait*() ID arguments (authored by kevans). · Explain WhyJun 4 2025, 1:51 AM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rG3eb26ef41ce8: kdump: nicer printing of wait*() ID arguments.