Page MenuHomeFreeBSD

usb/if_mos.c: Fix incorrect SPDX ID
ClosedPublic

Authored by ziaee on May 16 2025, 1:03 PM.
Tags
None
Referenced Files
F132266792: D50374.id155556.diff
Wed, Oct 15, 8:19 AM
Unknown Object (File)
Thu, Oct 9, 11:43 PM
Unknown Object (File)
Sat, Oct 4, 4:29 PM
Unknown Object (File)
Sat, Sep 27, 3:10 PM
Unknown Object (File)
Fri, Sep 26, 6:32 PM
Unknown Object (File)
Wed, Sep 24, 2:58 AM
Unknown Object (File)
Wed, Sep 24, 1:03 AM
Unknown Object (File)
Tue, Sep 23, 2:34 AM
Subscribers
None

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ziaee requested review of this revision.May 16 2025, 1:03 PM
ziaee created this revision.

@imp can you please take a look to this change?

@ziaee, if @imp approve it, it's ok for me too :)

sys/dev/usb/net/if_mos.c
4

I hate to be a pain... But I think this tag was originally misplaced, in addition to being wrong.

So, I'd actually break a little with practice since we have so many copyright notices and add

/* SPDX-License-Identifier: ISC AND BSD-4-Clause */

as the first two lines of the file and delete the old, wrong one. I'd resist the urge to remove the '-' at the end of the line since that makes the first copyright inconsistent with the rest. It also isn't worth the churn to fix the rest. It's kinda sorta contrib code since it looks like it came from OpenBSD, even though Rick clearly did a lot of work to port it to FreeBSD.

sys/dev/usb/net/if_mos.c
4

Okay, so the patch just needs the - added back and then it's fine?

sys/dev/usb/net/if_mos.c
4

It needs that, but also I was suggesting moving the SPDX line to the first line of the file, followed by a blank line, followed by the original third line of the file.

Yes. Thanks. Sorry to be so notpicky...

This revision is now accepted and ready to land.May 24 2025, 8:35 AM

Sorry to be so nitpicky...

Please don't be, this kind of stuff makes our quality high, and if our quality is high we will attract the right people. I do not believe marketing can attract them, I think only precision and quality will attract them. Thanks for the help.

This revision was automatically updated to reflect the committed changes.