Fixes: 718cf2ccb995 (further adoption of SPDX)
MFC after: 3 days
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/dev/usb/net/if_mos.c | ||
|---|---|---|
| 4 | I hate to be a pain... But I think this tag was originally misplaced, in addition to being wrong. So, I'd actually break a little with practice since we have so many copyright notices and add /* SPDX-License-Identifier: ISC AND BSD-4-Clause */ as the first two lines of the file and delete the old, wrong one. I'd resist the urge to remove the '-' at the end of the line since that makes the first copyright inconsistent with the rest. It also isn't worth the churn to fix the rest. It's kinda sorta contrib code since it looks like it came from OpenBSD, even though Rick clearly did a lot of work to port it to FreeBSD. | |
| sys/dev/usb/net/if_mos.c | ||
|---|---|---|
| 4 | Okay, so the patch just needs the - added back and then it's fine? | |
| sys/dev/usb/net/if_mos.c | ||
|---|---|---|
| 4 | It needs that, but also I was suggesting moving the SPDX line to the first line of the file, followed by a blank line, followed by the original third line of the file. | |
Comment Actions
Sorry to be so nitpicky...
Please don't be, this kind of stuff makes our quality high, and if our quality is high we will attract the right people. I do not believe marketing can attract them, I think only precision and quality will attract them. Thanks for the help.