acpi_cros_kblt: New driver for Chromebook keyboard backlight control
Needs ReviewPublic
Actions

Authored by val_packett.cool on Sep 21 2019, 10:02 PM.

Details

Reviewers

imp
manu

Group Reviewers

Contributor Reviews (src)
desktop

Summary

Allows adjusting keyboard backlight level on amd64 Chromebooks, restores it on resume from sleep.

Sponsored by: https://www.patreon.com/valpackett

Test Plan

Tested on: Google Pixelbook (eve)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49520
Build 46410: arc lint + arc unit

Event Timeline

val_packett.cool created this revision.Sep 21 2019, 10:02 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 21 2019, 10:02 PM

I was going to suggest adding the devmatch changes, but no other ACPI driver seems to have them yet, so I can do that in a sweep.

This revision is now accepted and ready to land.Sep 21 2019, 10:15 PM

Yeah, I was wondering about devmatch in D21612

val_packett.cool mentioned this in D26250: Add backlight subsystem.Sep 4 2020, 5:19 PM

Use backlight(9) subsystem
Add SPDX tag
Some formatting changes

@imp how's the ACPI devmatch work? :)

This revision now requires review to proceed.Mar 31 2021, 7:02 PM

Oops, with git now, we don't need $FreeBSD$ in the Makefile either

Man page?

Add man page and sys/conf/files entry

Harbormaster completed remote builds in B49520: Diff 116458.Feb 4 2023, 7:13 AM

val_packett.cool edited the summary of this revision. (Show Details)Feb 4 2023, 7:13 AM

val_packett.cool added a reviewer: desktop.

emaste added a subscriber: emaste.Feb 6 2023, 6:18 PM

Can this driver generate org.freedesktop.UPower.KbdBacklight events ?

In D21746#884483, @dmitryluhtionov_gmail.com wrote:

Can this driver generate org.freedesktop.UPower.KbdBacklight events ?

That's not a kernel thing, that can't be done *here*. upowerd needs integration with the backlight(9) system. But I think backlight(9) currently doesn't have event notifications. I'll look into that, but that's unrelated to drivers for particular hardware :)