Page MenuHomeFreeBSD

Introduce DP83867 PHY driver
ClosedPublic

Authored by mindal_semihalf.com on Nov 3 2021, 9:50 AM.

Details

Summary

DP83867 is a 10/100/1000 Texas Instruments PHY.
Only SGMII mode is supported.
Link status changes can be checked through an interrupt generated by the PHY if available

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

I'd like to test this review, but two errors occured when building. First one, unknown function 'device_get_property' means I need fresh sources (I see it in recently fetched git repository).
Second one, no member named 'mii_maxspeed' in 'struct mii_softc' I can't resolve recently - looking into file sys/dev/mii/miivar.h, where struct mii_softc is defined, does not show such member of structure.

I'd like to test this review, but two errors occured when building. First one, unknown function 'device_get_property' means I need fresh sources (I see it in recently fetched git repository).
Second one, no member named 'mii_maxspeed' in 'struct mii_softc' I can't resolve recently - looking into file sys/dev/mii/miivar.h, where struct mii_softc is defined, does not show such member of structure.

device_get_property code was merged into main a couple moths ago, so you need relatively fresh sources indeed.
The second error should dissapear after applying D32812 and D32727.

Looking a bit more into it, I think maxspeed variable and mii_maxspeed struct member is just read from DTB, but not used anywhere.

Looking a bit more into it, I think maxspeed variable and mii_maxspeed struct member is just read from DTB, but not used anywhere.

With D32727 applied it is used in mii_phy_dev_attach.

After some mail exchange regarding problem elsewhere, applied this review minus maxspeed handling for brevity, DP83867 PHY looks like working for me (I need to fix something else unrelated to this review to be sure) - at least media status sense and autonegotiation works as expected.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 24 2021, 6:42 AM
This revision was automatically updated to reflect the committed changes.