- User Since
- Nov 17 2021, 8:07 AM (27 w, 3 d)
Apr 4 2022
Fix probe issue pointed to by skibo
Inline comments made by mhorne addressed...
Apr 2 2022
This diff was done with -U99999 and module directory was renamed to sys/modules/if_cgem. Hopefully there is no space/tabs issue, now it should apply correctly.
Mar 31 2022
Mar 28 2022
Additional note: Makefile originally provided by Thomas Skibo, I'd like to attribute it properly.
New revision is just being created, https://reviews.freebsd.org/D34687, for building if_cgem.ko kernel module, used to test changes proposed here for miibus.ko kernel module
Mar 6 2022
Testing with 'make buildenv' revealed opt_platform.h is necessary as well. As part of normal buildkernel, this file is already created.
Minimal diff with new files added at the end.
Feb 19 2022
Feb 14 2022
Feb 12 2022
Original patch missed inclusion of VSCPHY driver, corrected here.
Nov 17 2021
After some mail exchange regarding problem elsewhere, applied this review minus maxspeed handling for brevity, DP83867 PHY looks like working for me (I need to fix something else unrelated to this review to be sure) - at least media status sense and autonegotiation works as expected.
Looking a bit more into it, I think maxspeed variable and mii_maxspeed struct member is just read from DTB, but not used anywhere.
I'd like to test this review, but two errors occured when building. First one, unknown function 'device_get_property' means I need fresh sources (I see it in recently fetched git repository).
Second one, no member named 'mii_maxspeed' in 'struct mii_softc' I can't resolve recently - looking into file sys/dev/mii/miivar.h, where struct mii_softc is defined, does not show such member of structure.