In D47878#1227393, @jhb wrote:

The memcpy size is wrong.

This is the important fix. The two prior changes are cleanups, but are pretty small. If you wanted to do an EN for 15.0, you could fix the size in the existing memcpy() to use __rangeof(), but this particular sort of bug is why we generally don't use memcpy() for this sort of thing.

In D47878#1227305, @olce wrote:

In D47878#1226923, @jhb wrote:

Actually, I found a bug in the compat32 setcred() as well. (...) I will work on some patches though I'll try to post for review today/tomorrow.

I've quickly reviewed again that code and fail to see any practical problem (there's a memcpy() that conceptually should operate on &wcred32.setcred32_copy_start instead of &wcred32, but that makes no difference in practice).

If you're unable to produce quickly a separate patch for this, could you please point me at the problem you've seen? I'd like to quickly assess if it's very easily fixable and, if that's the case, produce a minimal fix and then ask re@/cperciva@ whether they are OK to include it in 15.0.

Update rc.conf.5 too

Ok, so PlotSet() sets pl->data[j * pl->width + x] |= val where 0<=val<MAX_DS. So your assertion is true, but only because MAX_DS is a power of 2.

In D53747#1227297, @0mp wrote:

Looks OK.

Would you also have the time to document NAME_audit_user and audit_user in rc.conf(5)? In particular, the difference between command-based and function-based services is worth documenting.

pauamma corrections

Minor nits, fixable on commit.

emaste suggestions.
Removed 'would' for 'identifies'

Strip the license text

Looks good, one typo and two suggestions on articles.

In D53741#1227292, @0mp wrote:

Seems fine but would upstream accept it? What do you think?

In D47878#1226923, @jhb wrote:

Actually, I found a bug in the compat32 setcred() as well. (...) I will work on some patches though I'll try to post for review today/tomorrow.

?=

In D30315#1226268, @mat wrote:

In D30315#1225899, @mat wrote:

Also, ansible ahould probably not be using USE_PYTHON=concurrent

And I know I am the one who added it, but at the time, we did produce two packages for ansible, one for python 2 and one for python 3.

As we don't produce python 2 ports any more, concurrent should probably be removed from ports like ansible.

Looks OK.

With help from: mckusick

Seems fine but would upstream accept it? What do you think?

I have sent you my edit of the manual page in a separate email rather than trying to put all my comments into the above draft.

Yeah, the prefetching was tuned for a specific hardware configuration used years ago by a company that's no longer in business and from my notes it was a marginal improvement. I seem to recall @olivier seeing some even worse results on Atoms and such, so a solid good riddance to this added complexity.