Paths

Table of Contentst

Differential D47878

MAC: syscalls: mac_label_copyin(): 32-bit compatibility
AcceptedPublic
Actions

Authored by olce on Tue, Dec 3, 2:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 6, 6:07 AM

Subscribers

Details

Reviewers

emaste
bapt
brooks

Summary

A step on the way to support 32-bit compatibility for MAC-related system
calls. Needed by the upcoming setcred() system call.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60950
Build 57834: arc lint + arc unit

Event Timeline

olce created this revision.Tue, Dec 3, 2:54 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Dec 3, 2:54 PM

olce requested review of this revision.Tue, Dec 3, 2:54 PM

Harbormaster completed remote builds in B60926: Diff 147400.Tue, Dec 3, 2:55 PM

olce added a parent revision: D46905: MAC: syscalls: Split mac_set_proc() into reusable pieces.Tue, Dec 3, 2:57 PM

olce added inline comments.Tue, Dec 3, 2:59 PM

sys/security/mac/mac_syscalls.c
154–159	Well, sometimes it's enough to just upload some diff to get a problem back... Bracketing test for `COMPAT_FREEBSD32` is missing here, will add.

brooks added a subscriber: brooks.Tue, Dec 3, 5:56 PM

brooks added inline comments.

sys/security/mac/mac_syscalls.c
98	Why `_int`? Maybe `_impl`?
sys/security/mac/mac_syscalls.h
27	This must be named `struct mac32` to support freebsd32 system call stub generation. I'd also be tempted to forward declare it here and keep the real definition in mac_syscalls.c.

brooks added a child revision: D47618: New setcred() system call and associated MAC hooks.Tue, Dec 3, 6:06 PM

Apply brooks@'s request and suggestion.

Harbormaster completed remote builds in B60950: Diff 147456.Wed, Dec 4, 12:00 PM

olce added inline comments.Wed, Dec 4, 12:00 PM

sys/security/mac/mac_syscalls.c
98	`_int` for "internal". Renamed it to `_impl`.

brooks accepted this revision.Wed, Dec 4, 4:29 PM

This revision is now accepted and ready to land.Wed, Dec 4, 4:29 PM

Revision Contents
Changeset List

Path

Size

sys/

security/

mac/

7 lines

50 lines

Diff 147456

sys/security/mac/mac_syscalls.h

Loading...

sys/security/mac/mac_syscalls.c

Loading...