Page MenuHomeFreeBSD

MAC: syscalls: mac_label_copyin(): 32-bit compatibility
ClosedPublic

Authored by olce on Dec 3 2024, 2:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 19, 11:37 PM
Unknown Object (File)
Sat, Oct 18, 7:14 AM
Unknown Object (File)
Thu, Oct 16, 10:30 PM
Unknown Object (File)
Thu, Oct 9, 10:49 AM
Unknown Object (File)
Sun, Oct 5, 4:54 PM
Unknown Object (File)
Sep 13 2025, 4:23 PM
Unknown Object (File)
Sep 9 2025, 6:26 AM
Unknown Object (File)
Sep 6 2025, 5:39 PM
Subscribers

Details

Summary

A step on the way to support 32-bit compatibility for MAC-related system
calls. Needed by the upcoming setcred() system call.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60926
Build 57810: arc lint + arc unit

Event Timeline

olce requested review of this revision.Dec 3 2024, 2:54 PM
sys/security/mac/mac_syscalls.c
144–149

Well, sometimes it's enough to just upload some diff to get a problem back... Bracketing test for COMPAT_FREEBSD32 is missing here, will add.

brooks added inline comments.
sys/security/mac/mac_syscalls.c
91

Why _int? Maybe _impl?

sys/security/mac/mac_syscalls.h
27

This must be named struct mac32 to support freebsd32 system call stub generation.

I'd also be tempted to forward declare it here and keep the real definition in mac_syscalls.c.

olce marked 2 inline comments as done.

Apply brooks@'s request and suggestion.

sys/security/mac/mac_syscalls.c
91

_int for "internal". Renamed it to _impl.

This revision is now accepted and ready to land.Dec 4 2024, 4:29 PM