Page MenuHomeFreeBSD

MAC/do: Remove the 'prison0' special cases in the common paths
ClosedPublic

Authored by olce on Nov 15 2024, 5:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 13, 7:25 PM
Unknown Object (File)
Sun, Nov 9, 10:56 AM
Unknown Object (File)
Sat, Nov 8, 8:47 AM
Unknown Object (File)
Fri, Nov 7, 11:25 AM
Unknown Object (File)
Mon, Nov 3, 4:38 AM
Unknown Object (File)
Oct 21 2025, 9:13 PM
Unknown Object (File)
Oct 17 2025, 9:22 PM
Unknown Object (File)
Oct 11 2025, 7:32 PM

Details

Summary

This revision is part of a series. Click on the Stack tab below to see the context.
This series has also been squeezed into D47633 to provide an overall view.

Commit message:
The rules on 'prison0' are initialized in init(), now using
set_empty_rules().

Until the jail is destroyed, they can never be uninitialized by a call
to osd_jail_del(), since the only chain to call it is
mac_do_prison_set() -> remove_rules() -> osd_jail_del(), and
mac_do_prison_set() (method PR_METHOD_SET) can never be called on
'prison0'. This guarantees that find_rules() always find a valid
'rules' pointer to return.

There's no need to do anything special in destroy() for 'prison0', as
osd_jail_deregister() now takes care of it.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce requested review of this revision.Nov 15 2024, 5:07 PM
This revision is now accepted and ready to land.Nov 19 2024, 8:02 AM