Page MenuHomeFreeBSD

MAC/do: Remove the 'prison0' special cases in the common paths
ClosedPublic

Authored by olce on Nov 15 2024, 5:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 24, 9:16 PM
Unknown Object (File)
Wed, Sep 24, 8:55 PM
Unknown Object (File)
Wed, Sep 24, 3:20 AM
Unknown Object (File)
Wed, Sep 24, 3:19 AM
Unknown Object (File)
Tue, Sep 16, 5:24 PM
Unknown Object (File)
Sun, Sep 14, 1:51 PM
Unknown Object (File)
Aug 25 2025, 4:11 AM
Unknown Object (File)
Aug 18 2025, 5:25 PM

Details

Summary

This revision is part of a series. Click on the Stack tab below to see the context.
This series has also been squeezed into D47633 to provide an overall view.

Commit message:
The rules on 'prison0' are initialized in init(), now using
set_empty_rules().

Until the jail is destroyed, they can never be uninitialized by a call
to osd_jail_del(), since the only chain to call it is
mac_do_prison_set() -> remove_rules() -> osd_jail_del(), and
mac_do_prison_set() (method PR_METHOD_SET) can never be called on
'prison0'. This guarantees that find_rules() always find a valid
'rules' pointer to return.

There's no need to do anything special in destroy() for 'prison0', as
osd_jail_deregister() now takes care of it.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce requested review of this revision.Nov 15 2024, 5:07 PM
This revision is now accepted and ready to land.Nov 19 2024, 8:02 AM