Page MenuHomeFreeBSD

MAC/do: parse_rule_element(): Bug in parsing the origin ID
ClosedPublic

Authored by olce on Nov 15 2024, 5:07 PM.
Tags
None
Referenced Files
F169597394: D47612.diff
Wed, Sep 2, 12:51 AM
F169402595: D47612.diff
Tue, Sep 1, 10:50 AM
F169323091: D47612.id148063.diff
Tue, Sep 1, 4:57 AM
F169289792: D47612.id.diff
Tue, Sep 1, 3:33 AM
Unknown Object (File)
Mon, Aug 31, 11:28 AM
Unknown Object (File)
Sun, Aug 30, 5:47 AM
Unknown Object (File)
Sun, Aug 30, 1:01 AM
Unknown Object (File)
Sat, Aug 29, 4:01 PM

Details

Summary

This revision is part of a series. Click on the Stack tab below to see the context.
This series has also been squeezed into D47633 to provide an overall view.

Commit message:
The ID field was allowed to be empty, which would be then parsed as 0 by
strtol(). There remains bugs in this function, where parsing for from-
or to- IDs accepts spaces and produces 0, but this will conveniently be
fixed in a later commit introducing strtoui_strict().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce requested review of this revision.Nov 15 2024, 5:07 PM
This revision is now accepted and ready to land.Nov 19 2024, 8:05 AM