Page MenuHomeFreeBSD

MAC/do: parse_rules(): Copy input string on its own
ClosedPublic

Authored by olce on Nov 15 2024, 5:06 PM.
Tags
None
Referenced Files
F156514834: D47591.id146524.diff
Thu, May 14, 7:50 AM
F156514808: D47591.id146524.diff
Thu, May 14, 7:50 AM
Unknown Object (File)
Wed, May 13, 2:26 PM
Unknown Object (File)
Wed, May 13, 2:25 PM
Unknown Object (File)
Tue, May 12, 3:54 PM
Unknown Object (File)
Mon, Apr 27, 11:16 AM
Unknown Object (File)
Tue, Apr 21, 3:58 AM
Unknown Object (File)
Apr 11 2026, 11:58 AM

Details

Summary

This revision is part of a series. Click on the Stack tab below to see the context.
This series has also been squeezed into D47633 to provide an overall view.

Commit message:
Since all callers have to do it, save them that burden and do it in
parse_rules() instead.

While here, replace "strlen(x) == 0" with the simpler and more efficient
"x[0] == '\0'".

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce requested review of this revision.Nov 15 2024, 5:06 PM

In the proposed commit message, I guess you mean:

While here, replace strlen(x) == 0 with the simpler and more efficient
x[0] == '\0'.

Note 0 and \0. I believe the later is better.

Note 0 and \0. I believe the later is better.

Yes. The initial version probably was using 0 and later I changed the code but forgetting to update the commit message. Will do.

This revision is now accepted and ready to land.Nov 19 2024, 7:47 AM