Page MenuHomeFreeBSD

MAC/do: parse_rules(): Copy input string on its own
ClosedPublic

Authored by olce on Nov 15 2024, 5:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 7, 2:29 PM
Unknown Object (File)
Sat, Feb 28, 7:28 PM
Unknown Object (File)
Mon, Feb 23, 10:21 AM
Unknown Object (File)
Feb 8 2026, 7:48 AM
Unknown Object (File)
Feb 7 2026, 9:15 PM
Unknown Object (File)
Feb 7 2026, 5:48 AM
Unknown Object (File)
Jan 31 2026, 4:09 AM
Unknown Object (File)
Jan 12 2026, 12:37 PM

Details

Summary

This revision is part of a series. Click on the Stack tab below to see the context.
This series has also been squeezed into D47633 to provide an overall view.

Commit message:
Since all callers have to do it, save them that burden and do it in
parse_rules() instead.

While here, replace "strlen(x) == 0" with the simpler and more efficient
"x[0] == '\0'".

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce requested review of this revision.Nov 15 2024, 5:06 PM

In the proposed commit message, I guess you mean:

While here, replace strlen(x) == 0 with the simpler and more efficient
x[0] == '\0'.

Note 0 and \0. I believe the later is better.

Note 0 and \0. I believe the later is better.

Yes. The initial version probably was using 0 and later I changed the code but forgetting to update the commit message. Will do.

This revision is now accepted and ready to land.Nov 19 2024, 7:47 AM