Page MenuHomeFreeBSD

MAC/do: Remove PR_METHOD_REMOVE method
ClosedPublic

Authored by olce on Nov 15 2024, 5:06 PM.
Tags
None
Referenced Files
F169769442: D47599.diff
Wed, Sep 2, 12:33 PM
F169698284: D47599.id148053.diff
Wed, Sep 2, 7:57 AM
F169561823: D47599.diff
Tue, Sep 1, 10:31 PM
F169537838: D47599.id.diff
Tue, Sep 1, 8:49 PM
Unknown Object (File)
Tue, Sep 1, 8:14 AM
Unknown Object (File)
Tue, Sep 1, 3:43 AM
Unknown Object (File)
Mon, Aug 31, 12:23 PM
Unknown Object (File)
Sun, Aug 30, 7:01 PM

Details

Summary

This revision is part of a series. Click on the Stack tab below to see the context.
This series has also been squeezed into D47633 to provide an overall view.

Commit message:
It isn't really needed, since common jail code destroys jail OSD storage
at jail destruction (via osd_jail_exit()), triggering our destructor
dealloc_osd(). Leveraging this mechanism is arguably even better as it
causes deallocation to always happen without the 'allprison_lock' lock.

While here, make the static definition of 'methods' top-level, renaming
it to 'osd_methods'.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce requested review of this revision.Nov 15 2024, 5:06 PM
This revision is now accepted and ready to land.Nov 19 2024, 7:59 AM
sys/security/mac_do/mac_do.c
448

Should the const qualifier be dropped?

sys/security/mac_do/mac_do.c
448

What for? Jail methods are not supposed to be dynamically changed.

I may have guessed why you're asking this, and if so the answer is here: D46886.

sys/security/mac_do/mac_do.c
448

Ah yes, Nice!

olce marked 2 inline comments as done.Nov 26 2024, 2:22 PM
This revision was automatically updated to reflect the committed changes.