Page MenuHomeFreeBSD

syscallsubr.h: Header inclusions: Explicit <sys/types.h>, sort
ClosedPublic

Authored by olce on Dec 3 2024, 4:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 1, 2:44 AM
Unknown Object (File)
Tue, Feb 18, 6:18 PM
Unknown Object (File)
Feb 10 2025, 7:29 PM
Unknown Object (File)
Feb 8 2025, 5:30 AM
Unknown Object (File)
Jan 27 2025, 3:00 AM
Unknown Object (File)
Jan 26 2025, 5:05 AM
Unknown Object (File)
Jan 16 2025, 9:58 PM
Unknown Object (File)
Jan 12 2025, 8:16 PM
Subscribers

Details

Summary

<sys/types.h> is currently brought in by other headers but some of its
type definition are directly used in this header, so it should appear
explicitly. It is necessary as lots of prototypes in there use types it
defines (<sys/_types.h> wouldn't be enough).

Sort header inclusions as per style(9).

No functional change (intended).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce requested review of this revision.Dec 3 2024, 4:57 PM

So if sys/_types.h won't suffice, I'd call out why in the commit message (this file makes no pretense of being namespace clean I think would be the reason.)

In D47881#1091936, @imp wrote:

So if sys/_types.h won't suffice, I'd call out why in the commit message (this file makes no pretense of being namespace clean I think would be the reason.)

Commit message amended.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 16 2024, 2:46 PM
This revision was automatically updated to reflect the committed changes.