bhyve: Eliminate exit status magic numbers
AcceptedPublic
Actions

Authored by bnovkov on Thu, Nov 13, 11:13 AM.

Details

Reviewers

markj
andrew
corvink
emaste

Group Reviewers

bhyve

Summary

bhyve's exit status codes indicate how the VM was terminated.
Unfortunately, their meaning within the source code is somewhat
unclear since they are only used as magic numbers.

Fix this by defining exit status macros and using them to replace
the magic numbers in exit(3) function calls.

Sponsored by: The FreeBSD Foundation
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

bnovkov created this revision.Thu, Nov 13, 11:13 AM

Herald added a reviewer: andrew. · View Herald TranscriptThu, Nov 13, 11:13 AM

Herald added subscribers: bcran, rgrimes, emaste, imp. · View Herald Transcript

Harbormaster completed remote builds in B68596: Diff 166352.Thu, Nov 13, 11:13 AM

bnovkov requested review of this revision.Thu, Nov 13, 11:13 AM

bnovkov added a parent revision: D53729: vmm: Add ability to destroy VMs on close.

bnovkov added a child revision: D53731: bhyve: Introduce monitor mode.

markj accepted this revision as: markj.Thu, Nov 13, 3:46 PM

This revision is now accepted and ready to land.Thu, Nov 13, 3:46 PM

corvink accepted this revision.Fri, Nov 14, 6:59 AM

emaste added inline comments.Fri, Nov 14, 1:44 PM

usr.sbin/bhyve/bhyverun.h
37	Maybe comments here and in bhyve.8 mentioning that this list also exists in the other one?

Address @emaste 's comment.

This revision now requires review to proceed.Mon, Nov 17, 2:54 PM

bnovkov marked an inline comment as done.Mon, Nov 17, 2:56 PM

bnovkov added inline comments.

usr.sbin/bhyve/bhyverun.h
37	Thanks for the suggestion, I've added a reference to the manpage here. I don't think it makes sense to reference the `bhyverun.h` list in the manpage.