Paths

Table of Contentst

setcred: Move initial copyin of struct setcred out to per-ABI syscall
AcceptedPublic
Actions

Authored by jhb on Fri, Nov 14, 2:55 PM.

Tags

None

Referenced Files

	F136138803: D53756.id166454.diff
	Sun, Nov 16, 2:39 AM

	F136138525: D53756.diff
	Sun, Nov 16, 2:35 AM

	F136063083: D53756.id.diff
	Sat, Nov 15, 12:11 PM

	F136051297: D53756.id166454.diff
	Sat, Nov 15, 10:05 AM

	F136044367: D53756.diff
	Sat, Nov 15, 8:53 AM

	F136036259: D53756.id166454.diff
	Sat, Nov 15, 7:25 AM

	F136028993: D53756.id166454.diff
	Sat, Nov 15, 5:45 AM

	F136026699: D53756.id.diff
	Sat, Nov 15, 5:16 AM

View All 11 Files

Subscribers

emaste

imp

Details

Reviewers

olce

Group Reviewers

cheri

Summary

This is the more typical approach used in the tree for system calls
with per-ABI structure layouts.

Obtained from: CheriBSD
Sponsored by: AFRL, DARPA

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68636
Build 65519: arc lint + arc unit

Event Timeline

jhb created this revision.Fri, Nov 14, 2:55 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Nov 14, 2:55 PM

jhb requested review of this revision.Fri, Nov 14, 2:55 PM

Harbormaster completed remote builds in B68636: Diff 166454.Fri, Nov 14, 2:55 PM

Herald added a reviewer: cheri. · View Herald TranscriptFri, Nov 14, 2:55 PM

Herald added a reviewer: cheri. · View Herald Transcript

jhb added a parent revision: D53755: MAC: Use the current thread's user ABI to determine the layout of struct mac.Fri, Nov 14, 2:55 PM

jhb added a child revision: D53757: freebsd32_setcred: Copy all of the setcred fields.

emaste added a subscriber: emaste.Fri, Nov 14, 3:23 PM

olce accepted this revision.Fri, Nov 14, 5:51 PM

olce added inline comments.

sys/kern/kern_prot.c
573	I'd keep the `const` here.
sys/sys/ucred.h
202	Consistenly with the above inline comment.

This revision is now accepted and ready to land.Fri, Nov 14, 5:51 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

freebsd32/

freebsd32_misc.c

18 lines

kern/

kern_prot.c

52 lines

sys/

ucred.h

4 lines

Diff 166454

View Options

sys/compat/freebsd32/freebsd32_misc.c

View Options

sys/kern/kern_prot.c

View Options

setcred: Move initial copyin of struct setcred out to per-ABI syscallAcceptedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 166454

sys/compat/freebsd32/freebsd32_misc.c

sys/kern/kern_prot.c

sys/sys/ucred.h

setcred: Move initial copyin of struct setcred out to per-ABI syscall
AcceptedPublic
Actions

Revision Contents
Changeset List