Paths

Table of Contentst

Differential D60738

net*: remove remnants of caddr_t
AbandonedPublic
Actions

Authored by glebius on Thu, Oct 15, 4:45 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 16, 2:30 PM

	Unknown Object (File)
	Fri, Oct 16, 2:25 PM

	Unknown Object (File)
	Fri, Oct 16, 1:58 PM

	Unknown Object (File)
	Fri, Oct 16, 7:20 AM

	Unknown Object (File)
	Fri, Oct 16, 12:52 AM

	Unknown Object (File)
	Thu, Oct 15, 10:02 PM

	Unknown Object (File)
	Thu, Oct 15, 8:34 PM

	Unknown Object (File)
	Thu, Oct 15, 5:23 PM

View All 12 Files

Subscribers

Details

Reviewers

shurd
melifaro
zlei
glebius

Group Reviewers

transport
network
iflib

Commits

rGd7cf2e714e29: net*: remove remnants of caddr_t

Summary

caddr_t is a typedef for a character pointer (char *) that originated in
Version 7 Unix, released by AT&T in 1979. It became obsolete in 1989,
when ANSI C introduced void *.

What's left:

ioctl(9) KPI still uses caddr_t, thus network related ioctl method still use it.
if_clone KPI, to be done separately.
bpf(4), to be done separately.
SCTP, let maintainers decide.
iflib(4), let maintainers decide.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 78233
Build 75116: arc lint + arc unit

Event Timeline

glebius created this revision.Thu, Oct 15, 4:45 AM

Herald added a reviewer: shurd. · View Herald TranscriptThu, Oct 15, 4:45 AM

Herald added a reviewer: melifaro. · View Herald Transcript

Herald added 1 blocking reviewer(s): transport. · View Herald Transcript

Herald added a reviewer: iflib. · View Herald Transcript

Herald added subscribers: pouria, ivy, donner and 3 others. · View Herald Transcript

glebius requested review of this revision.Thu, Oct 15, 4:45 AM

Harbormaster completed remote builds in B78233: Diff 189950.Thu, Oct 15, 4:45 AM

glebius added a parent revision: D60736: mbuf: remove remnants of caddr_t.Thu, Oct 15, 4:45 AM

glebius added a child revision: D60688: mbuf: make m_pullup() an inline over most expected case.Thu, Oct 15, 4:46 AM

glebius mentioned this in D60689: net*: use inlined m_pullup().Thu, Oct 15, 4:54 AM

Generally looks good to me.

sys/netinet/ip_input.c
1020	No need to cast to `char *`.
sys/netinet/tcp_output.c
2101
sys/netinet/tcp_stacks/rack.c
18121
sys/netinet/tcp_subr.c
1799
1799	Given `m` is a new allocated mbuf, I believe that `ip6` will not overlap with the mbuf data. So we can safely use `memcpy()` other than `bcopy()`. Let transport decide.
1812
1846
1860
sys/netinet6/icmp6.c
1423	We can use memcpy here.
sys/netinet6/ip6_input.c
1032	Can safely use memcpy.
sys/netinet6/ip6_output.c
3194	Can safely use memcpy.

There are many places where memcpy() can be used. I don't want to mix that into this commit.

Commited d7cf2e714e29a52264fa4bc67e7d727948003afb

glebius added a commit: rGd7cf2e714e29: net*: remove remnants of caddr_t.Sat, Oct 17, 3:04 AM

Revision Contents
Changeset List

Path

Size

sys/

net/

12 lines

8 lines

8 lines

16 lines

6 lines

2 lines

6 lines

4 lines

4 lines

3 lines

2 lines

2 lines

4 lines

2 lines

34 lines

netinet/

2 lines

4 lines

2 lines

2 lines

2 lines

17 lines

4 lines

10 lines

6 lines

4 lines

libalias/

2 lines

4 lines

10 lines

8 lines

7 lines

10 lines

tcp_stacks/

7 lines

15 lines

33 lines

2 lines

2 lines

4 lines

netinet6/

4 lines

7 lines

40 lines

6 lines

20 lines

2 lines

14 lines

3 lines

2 lines

6 lines

14 lines

6 lines

2 lines

4 lines

6 lines

Diff 189950

sys/net/bridgestp.c

Loading...

sys/net/if.c

Loading...

sys/net/if_arp.h

Loading...

sys/net/if_bridge.c

Loading...

sys/net/if_bridgevar.h

Loading...

sys/net/if_ethersubr.c

Loading...

sys/net/if_geneve.c

Loading...

sys/net/if_ovpn.c

Loading...

sys/net/if_stf.c

Loading...

sys/net/if_vxlan.c

Loading...

sys/net/iflib.h

Loading...

sys/net/pfkeyv2.h

Loading...

sys/net/radix.h

Loading...

sys/net/route.c

Loading...

sys/net/rtsock.c

Loading...

sys/netinet/if_ether.c

Loading...

sys/netinet/in_rss.c

Loading...

sys/netinet/ip_carp.c

Loading...

sys/netinet/ip_fastfwd.c

Loading...

sys/netinet/ip_gre.c

Loading...

sys/netinet/ip_icmp.c

Loading...

sys/netinet/ip_input.c

Loading...

sys/netinet/ip_mroute.c

Loading...

sys/netinet/ip_options.c

Loading...

sys/netinet/ip_output.c

Loading...

sys/netinet/libalias/alias.c

Loading...

sys/netinet/siftr.c

Loading...

sys/netinet/tcp_input.c

Loading...

sys/netinet/tcp_log_buf.c

Loading...

sys/netinet/tcp_lro.c

Loading...

sys/netinet/tcp_output.c

Loading...

sys/netinet/tcp_stacks/bbr.c

Loading...

sys/netinet/tcp_stacks/rack.c

Loading...

sys/netinet/tcp_subr.c

Loading...

sys/netinet/tcp_syncache.c

Loading...

sys/netinet/tcp_usrreq.c

Loading...

sys/netinet/udp_usrreq.c

Loading...

sys/netinet6/dest6.c

Loading...

sys/netinet6/frag6.c

Loading...

sys/netinet6/icmp6.c

Loading...

sys/netinet6/in6_rss.c

Loading...

sys/netinet6/ip6_input.c

Loading...

sys/netinet6/ip6_mroute.c

Loading...

sys/netinet6/ip6_output.c

Loading...

sys/netinet6/mld6.c

Loading...

sys/netinet6/nd6.h

Loading...

sys/netinet6/nd6.c

Loading...

sys/netinet6/nd6_nbr.c

Loading...

sys/netinet6/nd6_rtr.c

Loading...

sys/netinet6/raw_ip6.c

Loading...

sys/netinet6/route6.c

Loading...

sys/netinet6/udp6_usrreq.c

Loading...