tcp: avoid disclosing uninitialize data in tcp_log code
AcceptedPublic
Actions

Authored by chs on Thu, Sep 24, 12:09 AM.

Details

Reviewers

imp
nickbanks_netflix.com
tuexen

Group Reviewers

transport

Summary

Zero various structures completely before filling in parts of them,
since we copy these entire structures out to userspace later.
Found with KMSAN.

Sponsored by: Netflix
Assisted-By: Claude Code - Opus 5 (1M context)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77234
Build 74117: arc lint + arc unit

Event Timeline

chs created this revision.Thu, Sep 24, 12:09 AM

Herald added a reviewer: transport. · View Herald TranscriptThu, Sep 24, 12:09 AM

Herald added subscribers: glebius, melifaro. · View Herald Transcript

chs requested review of this revision.Thu, Sep 24, 12:09 AM

Harbormaster completed remote builds in B77234: Diff 187547.Thu, Sep 24, 12:09 AM

chs added a parent revision: D59949: kmsan: avoid false reports while processing NMIs.Thu, Sep 24, 12:09 AM

chs added a child revision: D59951: zfs: avoid disclosing uninitialized data in various zil functions.

nickbanks_netflix.com accepted this revision.Thu, Sep 24, 12:19 PM

This revision is now accepted and ready to land.Thu, Sep 24, 12:19 PM

tuexen accepted this revision.Thu, Sep 24, 12:32 PM

tuexen added a subscriber: tuexen.

tuexen added inline comments.

sys/netinet/tcp_log_buf.c
1910	This is not needed. `optlen` can't be negative.

tuexen added inline comments.Thu, Sep 24, 12:35 PM

sys/netinet/tcp_log_buf.c
1907	Right now, `sizeof(log_buf->tlb_opts)` is `TCP_MAXOLEN` and therefore the `optlen` can't be larger than `TCP_MAXOLEN. So this is not needed.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_log_buf.c

20 lines

Diff 187547

View Options

tcp: avoid disclosing uninitialize data in tcp_log codeAcceptedPublicActions