geom_disk: fix the post-read KMSAN check
Needs ReviewPublic
Actions

Authored by chs on Thu, Sep 24, 12:10 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Sep 24, 5:34 PM

	Unknown Object (File)
	Thu, Sep 24, 5:01 PM

	Unknown Object (File)
	Thu, Sep 24, 3:39 PM

	Unknown Object (File)
	Thu, Sep 24, 2:31 PM

	Unknown Object (File)
	Thu, Sep 24, 9:14 AM

	Unknown Object (File)
	Thu, Sep 24, 9:01 AM

	Unknown Object (File)
	Thu, Sep 24, 1:42 AM

Subscribers

None

Details

Reviewers

imp

Summary

in g_disk_done() fix several problems with the post-read KMSAN check:

only check the range of the specific bio at hand, not the entire original bio.
only check if the read completed successfully.
only check if the bio is not BIO_UNMAPPED.

Found with KMSAN.

Sponsored by: Netflix
Assisted-By: Claude Code - Opus 5 (1M context)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77240
Build 74123: arc lint + arc unit

Event Timeline

chs requested review of this revision.Thu, Sep 24, 12:10 AM

chs created this revision.

Harbormaster completed remote builds in B77240: Diff 187553.Thu, Sep 24, 12:10 AM

chs added a parent revision: D59955: urndis: avoid KMSAN report.Thu, Sep 24, 12:10 AM

chs added a child revision: D59957: pfil: avoid disclosing uninitialized data in pfil ioctls.

Revision Contents
Changeset List

Path

Size

sys/

geom/

geom_disk.c

19 lines

Diff 187553

View Options

geom_disk: fix the post-read KMSAN checkNeeds ReviewPublicActions