Page MenuHomeFreeBSD
Differential D31673

LinuxKPI: Remove FreeBSD struct resource from all LKPI headers
ClosedPublic
Actions

Authored by wulf on Aug 24 2021, 11:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 13, 12:12 AM
Unknown Object (File)
Wed, May 13, 12:12 AM
Unknown Object (File)
Wed, May 13, 12:12 AM
Unknown Object (File)
Wed, May 13, 12:06 AM
Unknown Object (File)
Mon, May 4, 3:37 PM
Unknown Object (File)
Mon, May 4, 5:16 AM
Unknown Object (File)
Sun, May 3, 1:47 PM
Unknown Object (File)
Thu, Apr 30, 8:20 AM
View All Files
Subscribers
emaste
imp
linuxkpi

Details

Reviewers
• hselasky
manu
bz
Commits
rGfd6adf784e86: LinuxKPI: Remove FreeBSD struct resource from all LKPI headers
rG66ea390652d2: LinuxKPI: Remove FreeBSD struct resource from all LKPI headers
Summary

Remove FreeBSD struct resource from all LKPI headers
except linux/pci.h to avoid conflicts with Linux version.
This allows to #define resource in drm-kmod globally and strip a lot of #ifdef-s

MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

wulf created this revision.Aug 24 2021, 11:52 PM
Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptAug 24 2021, 11:52 PM
wulf requested review of this revision.Aug 24 2021, 11:52 PM
Harbormaster completed remote builds in B41194: Diff 94152.Aug 24 2021, 11:52 PM
• hselasky added a comment.Aug 25 2021, 7:46 AM

Where did the tasklet support go?

sys/compat/linuxkpi/common/include/linux/interrupt.h
107

"device" is no longer __unused here.

wulf updated this revision to Diff 94160.Aug 25 2021, 9:07 AM

Remove extraneous __unused tag

Harbormaster completed remote builds in B41197: Diff 94160.Aug 25 2021, 9:07 AM
wulf added a comment.Aug 25 2021, 9:15 AM
In D31673#714450, @hselasky wrote:

Where did the tasklet support go?

They are left untouched. Nothing happened.

Probably you are confused by using of sys/compat/linuxkpi/common/include/linux/interrupt.h as a base of two diffs.

manu accepted this revision.Aug 25 2021, 9:22 AM
This revision is now accepted and ready to land.Aug 25 2021, 9:22 AM
• hselasky accepted this revision.Aug 25 2021, 9:34 AM

Make sure you build the kernel WITH_OFED=YES

wulf mentioned this in D32168: LinuxKPI: Hide some symbols in linux_interrupt.c.Sep 27 2021, 11:51 PM
bz added a child revision: D32168: LinuxKPI: Hide some symbols in linux_interrupt.c.Sep 28 2021, 7:09 AM
Closed by commit rG66ea390652d2: LinuxKPI: Remove FreeBSD struct resource from all LKPI headers (authored by wulf). · Explain WhySep 29 2021, 8:28 PM
This revision was automatically updated to reflect the committed changes.
wulf added a commit: rG66ea390652d2: LinuxKPI: Remove FreeBSD struct resource from all LKPI headers.
wulf added a commit: rGfd6adf784e86: LinuxKPI: Remove FreeBSD struct resource from all LKPI headers.Oct 13 2021, 9:20 AM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
168 lines
src/
41 lines
src/
linux_interrupt.c/
include/
linux/
interrupt.h
167 lines
conf/
2 lines
modules/
linuxkpi/
1 line

Diff 95972

View Options

sys/compat/linuxkpi/common/include/linux/interrupt.h

Loading...
View Options

sys/compat/linuxkpi/common/src/linux_compat.c

Loading...
View Options

sys/compat/linuxkpi/common/src/linux_interrupt.c

Loading...
View Options

sys/conf/files

Loading...
View Options

sys/modules/linuxkpi/Makefile

Loading...