Differential D31558

Retire MK_PROFILE infrastructure
ClosedPublic
Actions

Authored by emaste on Aug 16 2021, 3:00 PM.

Tags

None

Referenced Files

	F154993837: D31558.id93753.diff
	Thu, Apr 30, 1:28 PM

	F154993834: D31558.id93753.diff
	Thu, Apr 30, 1:28 PM

	Unknown Object (File)
	Sat, Apr 25, 8:08 PM

	Unknown Object (File)
	Fri, Apr 24, 11:30 PM

	Unknown Object (File)
	Sun, Apr 19, 1:51 AM

	Unknown Object (File)
	Sat, Apr 18, 9:56 AM

	Unknown Object (File)
	Sat, Apr 18, 5:29 AM

	Unknown Object (File)
	Sat, Apr 18, 5:22 AM

Subscribers

Details

Reviewers

imp
phk
manu

Group Reviewers

Commits

rG3750ccefb862: Retire MK_PROFILE infrastructure

Summary

We announced that the option would be removed before FreeBSD 14; it was
first disabled by default in fe52b7f60ef4.

Relnotes:       Yes
Sponsored by:   The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste created this revision.Aug 16 2021, 3:00 PM

Herald added subscribers: dab, bdrewery. · View Herald TranscriptAug 16 2021, 3:00 PM

TODO: determine if we can/should reuse any of this for code coverage (idea from @phk)

emaste added reviewers: imp, phk.Apr 30 2022, 2:00 PM

Herald added a reviewer: manu. · View Herald TranscriptApr 30 2022, 2:00 PM

emaste added a subscriber: sjg.Apr 30 2022, 2:08 PM

emaste added inline comments.

contrib/bmake/mk/lib.mk
258–260 ↗	(On Diff #93753)	@sjg, this would have no effect after my change but would you want to leave it to reduce diffs against upstream?

I changed the WITH_PROFILE description in f768ecf247b7acd98fd0ee395522e559769e3e51 as it may not be gone in 14.

rebase

Herald added a subscriber: jrtc27. · View Herald TranscriptNov 12 2024, 2:26 PM

14 you say?

This revision is now accepted and ready to land.Nov 12 2024, 2:28 PM

Updated proposed commit message to

It was disabled by default in fe52b7f60ef4.  We planned to (but did not)
remove the option before FreeBSD 14.  Remove it now, for FreeBSD 15.

I would generally leave contrib alone

contrib/bmake/mk/lib.mk
258–260 ↗	(On Diff #93753)	Leave it - it isn't used in freebsd and other systems still use profiling

emaste added a commit: rG3750ccefb862: Retire MK_PROFILE infrastructure.Nov 12 2024, 6:12 PM

Closed by commit rG3750ccefb862: Retire MK_PROFILE infrastructure (authored by emaste). · Explain WhyNov 14 2024, 8:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

11 lines

ObsoleteFiles.inc

183 lines

cddl/

lib/

libzpool/

3 lines

lib/

libc++experimental/

1 line

libc_nonshared/

1 line

libclang_rt/

1 line

libcompiler_rt/

3 lines

libiconv_modules/

1 line

libpam/

libpam/

2 lines

modules/

1 line

libprocstat/

2 lines

librpcsec_gss/

1 line

libssp_nonshared/

1 line

libthr/

3 lines

libulog/

3 lines

ncurses/

form/

3 lines

menu/

3 lines

ncurses/

6 lines

panel/

3 lines

tinfo/

8 lines

ofed/

complib/

1 line

libbnxtre/

1 line

libcxgb4/

1 line

libibcm/

1 line

libibmad/

1 line

libibnetdisc/

1 line

libibumad/

1 line

libibverbs/

1 line

libirdma/

1 line

libmlx4/

1 line

libmlx5/

1 line

libopensm/

1 line

librdmacm/

1 line

libvendor/

1 line

release/

4 lines

sbin/

nvmecontrol/

modules/

1 line

share/

mk/

16 lines

1 line

stand/

1 line

targets/

pseudo/

bootstrap-tools/

1 line

tools/

build/

mk/

OptionalObsoleteFiles.inc

184 lines

usr.bin/

lex/

lib/

5 lines

Diff 146472

Makefile.inc1

Loading...

ObsoleteFiles.inc

Loading...

cddl/lib/libzpool/Makefile

Loading...

lib/libc++experimental/Makefile

Loading...

lib/libc_nonshared/Makefile

Loading...

lib/libclang_rt/Makefile.inc

Loading...

lib/libcompiler_rt/Makefile

Loading...

lib/libiconv_modules/Makefile.inc

Loading...

lib/libpam/libpam/Makefile

Loading...

lib/libpam/modules/Makefile.inc

Loading...

lib/libprocstat/Makefile

Loading...

lib/librpcsec_gss/Makefile

Loading...

lib/libssp_nonshared/Makefile

Loading...

lib/libthr/Makefile

Loading...

lib/libulog/Makefile

Loading...

lib/ncurses/form/Makefile

Loading...

lib/ncurses/menu/Makefile

Loading...

lib/ncurses/ncurses/Makefile

Loading...

lib/ncurses/panel/Makefile

Loading...

lib/ncurses/tinfo/Makefile

Loading...

lib/ofed/complib/Makefile

Loading...

lib/ofed/libbnxtre/Makefile

Loading...

lib/ofed/libcxgb4/Makefile

Loading...

lib/ofed/libibcm/Makefile

Loading...

lib/ofed/libibmad/Makefile

Loading...

lib/ofed/libibnetdisc/Makefile

Loading...

lib/ofed/libibumad/Makefile

Loading...

lib/ofed/libibverbs/Makefile

Loading...

lib/ofed/libirdma/Makefile

Loading...

lib/ofed/libmlx4/Makefile

Loading...

lib/ofed/libmlx5/Makefile

Loading...

lib/ofed/libopensm/Makefile

Loading...

lib/ofed/librdmacm/Makefile

Loading...

lib/ofed/libvendor/Makefile

Loading...

release/Makefile

Loading...

sbin/nvmecontrol/modules/Makefile.inc

Loading...

share/mk/bsd.lib.mk

Loading...

share/mk/bsd.opts.mk

Loading...

stand/defs.mk

Loading...

targets/pseudo/bootstrap-tools/Makefile

Loading...

tools/build/mk/OptionalObsoleteFiles.inc

Loading...

usr.bin/lex/lib/Makefile

Loading...