In D32053#723298, @mhorne wrote:

Why should the DMAP alias be writable? Its protections are supposed to be kept in sync with the corresponding KVA page. You add a comment to this effect in D32026, but I think pmap_change_props_locked() is still missing the code that actually updates the DMAP protections (at least I don't see it).

Uploaded patch context.

In D32098#724590, @swills wrote:

I don't know the base make stuff well enough to comment on it, but if devel/notcurses builds without ports ncurses with this change then it should be fine.

Remove obsolete endian conversions

I am fine with the swap pager changes.

Almost fine but don't forget to add 'Submitted by:' line. Go ahead after adding the line.

Don't forget to add clamav-lts port to security/Makefile.

Looks good. Just make sure "make buildkernel WITH_OFED=YES" passes.

Can you add one more commit to change copied port to the actual LTS port?

In D32008#722311, @mandree wrote:

Add "Differential Revision:" to commit message.

Thanks a lot, that's something I wanted to do for a long time.

These symbols are required to load on 13-STABLE kernel module built on 13.0-RELEASE. 13-STABLE alone does not require them exposed

In D32169#726062, @hselasky wrote:

Does "buildkernel WITH_OFED=YES" still build?

LGTM now. I would like to request peer review by ygy. Go ahead if ygy approved.

Add "Submitted by:" to commit message.

Use PMAP_HAS_DMAP instead of LP64
Optimize sg_pcopy_to_buffer() for !PMAP_HAS_DMAP case
Move kmap/kunmap implementation in to header file
Drop debugging printf

Since D25019 has been reopened, I abandon this.

Update commit message as suggested by meta.

I have already approved this. Feel free to commit with commit message Approved by: meta (maintainer).

Include Submitted by: line. Following two are popular format.

• Submitted by: yasu (myself)
• Submitted by: myself

Add 'Differential Revision:' to commit message.

Not bad but I would write commit message like this:

Add 'Differential Revision:' to commig message.

I found this device on my machine:

How much of this is used by drm-kmod? The parts which are not are probably MFCable as the iwlwifi work does not live in the tree yet and has no guarantees to stable/13.

Does "buildkernel WITH_OFED=YES" still build?

Looks good.

Advise that only the presence of a value matters