mlx5en: Add sysctl variable mapping driver name to IF name
ClosedPublic
Actions

Authored by vag.singh_oneconvergence.com on Sep 28 2021, 1:24 PM.

Details

Reviewers

kib
• hselasky

Commits

rGc31002454ea4: mlx5en: Add sysctl variable mapping driver name to IF name

Summary

[PATCH 09/31] FreeBSD OFED support for DPDK MLX5 PMD

HyperV is not enabling ROCE by default causing the OFED to
not create few SYSCTL variables that publish kernel interface
name. Due to this MLX5 PMD is not able to read kernel
interface name to get MAC address.

Added new sysctl variable in MLX5_EN driver to map the device
name to the interface name.

Test Plan

Tested on KVM, ESXi, and HyperV/Azure Hypervisors with FreeBSD 14.0-CURRENT and FreeBSD12.1-STABLE.

iperf
DPDK MLX5 PMD/testpmd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vag.singh_oneconvergence.com created this revision.Sep 28 2021, 1:24 PM

Herald added a subscriber: ae. · View Herald TranscriptSep 28 2021, 1:24 PM

vag.singh_oneconvergence.com requested review of this revision.Sep 28 2021, 1:24 PM

• hselasky added inline comments.Sep 29 2021, 6:56 AM

sys/dev/mlx5/mlx5_en/mlx5_en_main.c
4962	Why can't SYSCTL_ADD_STRING() be used here?

Hi,

The "if_name" array should be added to the mlx5e_priv, because the "ifp" is destroyed before the SYSCTL is destroyed, which may lead to a use-after-free situation.