Page MenuHomeFreeBSD

security/softether: use https site etc
AbandonedPublic

Authored by meta on Aug 3 2018, 2:39 AM.

Details

Reviewers
mat
pi
hrs
Summary
  • add LICENSE_FILE
  • use https site, upstream now provides https site
  • remove MAKE_JOBS_UNSAFE as it actually builds
  • do patch in post-patch, not post-extract
  • do everything in do-install
  • put DOS2UNIX_FILES, ONLY_FOR_ARCHSi in the right place

mat, if you have thoughts on Makefile issue on softether-devel port,
all issues are brought from softether port. Let's fix issues on softether
port. Then I copy softether to softether-devel and update softether-devel.

Bugzilla: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230047

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20537
Build 19962: arc lint + arc unit

Event Timeline

security/softether/Makefile
43

Why +=?

remove unnecessary use of +=

meta marked an inline comment as done.Aug 8 2018, 7:14 AM
meta added inline comments.
security/softether/Makefile
43

seems unnecessary, removed.

meta marked an inline comment as done.

similify DOS2UNIX_FILES

bump PORTREVISION due to do-install target change

Anything else? Will be maintainer timeout tomorrow.

security/softether/Makefile
16–37

All this appears too early. See Chapter 15. Order of Variables in Port Makefiles.

Anything else? Maintainer timeout now.

security/softether/Makefile
56–58

This, and the next change are wrong, they replace make(1) comments with sh(1) comments, which should not be done.

meta marked an inline comment as done.Oct 31 2018, 3:52 PM
meta added inline comments.
security/softether/Makefile
56–58

I cannot get you. You didn't say that in a review of -devel port I created before.
Can you show me how should Makefile be? Now I am the maintainer of this port. I accept your patches.

pkg-message: use sysrc rather than editing rc.conf.

remove unrelated file from diff